Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iotdin-imx8p: Update the devices contract #439

Merged
merged 1 commit into from
Aug 20, 2024
Merged

iotdin-imx8p: Update the devices contract #439

merged 1 commit into from
Aug 20, 2024

Conversation

vraevsky
Copy link
Contributor

Disable bluetooth and wifi in the devices contracts files. Reason: the CompuLab Autokit came without an IFM-WB i/o module.

@vraevsky
Copy link
Contributor Author

Hi @acostach

Please approve this PR.
Removed wifi and bluetooth from the contracts.

@acostach
Copy link
Contributor

Hi @vraevsky , so this is a temporary change to unblock automated testing until the wireless modules arrive, right?

Also, can you please amend the commit and add "Change-type: patch" above "Signed-off-by"? This is necessary for the contracts repository, unlike device repositories which use "Changelog-entry". Thanks

@acostach acostach requested review from acostach and floion August 19, 2024 10:56
@vraevsky
Copy link
Contributor Author

vraevsky commented Aug 19, 2024 •
edited
Loading

Hi @vraevsky , so this is a temporary change to unblock automated testing until the wireless modules arrive, right?

Yes, this is a temporary change.

Also, can you please amend the commit and add "Change-type: patch" above "Signed-off-by"? This is necessary for the contracts repository, unlike device repositories which use "Changelog-entry". Thanks

PR is done.

@vraevsky @acostach
iotdin-imx8p: Update the devices contract
6ba0c6f 
Disable bluetooth and wifi in the devices contracts files.
Reason: the CompuLab Autokit came without an IFM-WB i/o module.

Change-type: patch
Signed-off-by: Valentin Raevsky <[email protected]>
@flowzone-app flowzone-app bot enabled auto-merge August 20, 2024 06:19
@acostach acostach disabled auto-merge August 20, 2024 06:37
@acostach acostach enabled auto-merge August 20, 2024 06:38
@acostach acostach merged commit b8e72ae into balena-io:master Aug 20, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floion floion floion approved these changes

@acostach acostach acostach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vraevsky @acostach @floion