Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw.device-type: switch to using flashProtocol: jetsonFlashDirect #446

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Nov 26, 2024

... for devices which have detailed instructions in the jetson-flash repository.

Devices which are SD-CARD flashers stay un-changed, so do community boards which don't have dedicated pages in the jetson-flash documentation.

Needed by: balena-io/balena-sdk#1503
Change-type: patch

Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same review for everywhere partials were deleted. LGTM otherwise.

],
"flashIndicator": ["power LED is off"],
"bootDevice": ["Remove recovery mode jumper and power up the {{name}}"]
"bootDevice": ["Connect power to the {{name}}"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather not remove the partials for any of these becoming jetsonFlashDirect @acostach Let's keep them for historically purposes since creating these took effort and it's not bad to keep them around IMO other some technical debt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I added the partials back

... for devices which have detailed instructions in the jetson-flash
repository.

Devices which are SD-CARD flashers stay un-changed, so do
community boards which don't have dedicated pages in the
jetson-flash documentation.

Change-type: patch
Signed-off-by: Alexandru Costache <[email protected]>
@acostach acostach marked this pull request as draft December 4, 2024 13:16
auto-merge was automatically disabled December 4, 2024 13:16

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants