Add support and tests for capability specification via provides
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipex
force-pushed
the
capability-support
branch
10 times, most recently
from
eeb6ea9 to
1c1c1a3
Compare
pipex
force-pushed
the
capability-support
branch
2 times, most recently
from
d2b2177 to
db65841
Compare
This removes some code duplication between `satisfiesChildContract` and `getNotSatisfiedRequirements` Change-type: patch
pipex
force-pushed
the
capability-support
branch
from
db65841 to
2180cbb
Compare
This lines up better with the original specification and how contracts are being used by the OS Change-type: minor
pipex
force-pushed
the
capability-support
branch
from
2180cbb to
978c919
Compare
Using array cardinalities would result in the blueprint using the `Array.filter` function as the filter for the selector, causing the filtered set to always have size 0 Change-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
satisfiesChildContractandgetNotSatisfiedRequirementsfunctions to check for capabilities defined viaprovideson the current context. This PR is just surfacing some functionality that was already partially there but never tested.Change-type: minor
Depends-on: #79