-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable adding a note to the release #274
Conversation
3b5002b
to
d28226f
Compare
@klutchell I tried to follow what I did in my previous PR to get CI to run but not sure what went wrong. I'm looking to add the |
Hey @treygilliland, thanks for the additional contribution! It's difficult to tell, but I think you need an empty line between the commit title and the Commit-type in the body. e.g.
vs
I know it seems silly, our versioning is using a legacy tool that could use some TLC. |
Resolves: #194 |
d28226f
to
4041cd4
Compare
I think I added this but not sure. |
Ugh, I found what was wrong and it's worse than I thought. You'll need to make your Change-type: the last line of your commit, or at least at the bottom with other "footer" type entries, with your descriptive text in the body. Apologies for the confusion, but at least now we know where the culprit is! |
5b929fb
to
469c682
Compare
All good. I think I have done that now (also removed the other text) with no luck... |
For security reasons we need to add the |
Depends on: #275 |
Can you rebase your commit please @treygilliland ? |
469c682
to
ba525f2
Compare
ba525f2
to
28dfe6f
Compare
@pipex @klutchell added trim to if statement, please retag for CI when you get a chance (no rush) :) |
Change-type: minor
28dfe6f
to
4bf3f04
Compare
Thank you for the contribution @treygilliland ! |
This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs.
This PR has been modeled after a similar PR to add the --multi-dockerignore flag here
Change-type: minor