Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adding a note to the release #274

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

treygilliland
Copy link
Contributor

@treygilliland treygilliland commented Oct 31, 2023

This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs.

This PR has been modeled after a similar PR to add the --multi-dockerignore flag here

Change-type: minor

@treygilliland
Copy link
Contributor Author

@klutchell I tried to follow what I did in my previous PR to get CI to run but not sure what went wrong. I'm looking to add the --note flag so I can note which branch the release came from. Any help would be appreciated!

@klutchell
Copy link
Collaborator

Hey @treygilliland, thanks for the additional contribution!

It's difficult to tell, but I think you need an empty line between the commit title and the Commit-type in the body.

e.g.

Enable adding a note to the release
Change-type: minor

vs

Enable adding a note to the release

Change-type: minor

I know it seems silly, our versioning is using a legacy tool that could use some TLC.

@klutchell
Copy link
Collaborator

Resolves: #194

@treygilliland
Copy link
Contributor Author

Hey @treygilliland, thanks for the additional contribution!

It's difficult to tell, but I think you need an empty line between the commit title and the Commit-type in the body.

e.g.

Enable adding a note to the release
Change-type: minor

vs

Enable adding a note to the release

Change-type: minor

I know it seems silly, our versioning is using a legacy tool that could use some TLC.

I think I added this but not sure.

@klutchell
Copy link
Collaborator

Ugh, I found what was wrong and it's worse than I thought.

You'll need to make your Change-type: the last line of your commit, or at least at the bottom with other "footer" type entries, with your descriptive text in the body.

Apologies for the confusion, but at least now we know where the culprit is!

@treygilliland treygilliland force-pushed the add-note-option branch 3 times, most recently from 5b929fb to 469c682 Compare October 31, 2023 19:58
@treygilliland
Copy link
Contributor Author

Ugh, I found what was wrong and it's worse than I thought.

You'll need to make your Change-type: the last line of your commit, or at least at the bottom with other "footer" type entries, with your descriptive text in the body.

Apologies for the confusion, but at least now we know where the culprit is!

All good. I think I have done that now (also removed the other text) with no luck...

@klutchell
Copy link
Collaborator

For security reasons we need to add the ok-to-test label for every push, but it looks like it has started now.

@klutchell
Copy link
Collaborator

Depends on: #275

@klutchell
Copy link
Collaborator

Can you rebase your commit please @treygilliland ?

@treygilliland
Copy link
Contributor Author

@pipex @klutchell added trim to if statement, please retag for CI when you get a chance (no rush) :)

@klutchell klutchell merged commit aa666fb into balena-io:master Nov 1, 2023
51 checks passed
@klutchell
Copy link
Collaborator

Thank you for the contribution @treygilliland !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants