test

.github/actions/test/action.yml

@@ -56,7 +56,6 @@ runs:
 
         npm ci
         npm run lint
-        npm run make
         npm run package
         npm run wdio
 

forge.config.ts

@@ -7,6 +7,7 @@ import { MakerDMG } from '@electron-forge/maker-dmg';
 import { MakerAppImage } from '@reforged/maker-appimage';
 import { AutoUnpackNativesPlugin } from '@electron-forge/plugin-auto-unpack-natives';
 import { WebpackPlugin } from '@electron-forge/plugin-webpack';
+import { exec } from 'child_process';
 
 import { mainConfig, rendererConfig } from './webpack.config';
 import * as sidecar from './forge.sidecar';
@@ -153,6 +154,23 @@ const config: ForgeConfig = {
 
 			return packageJson;
 		},
+		postPackage: async (_forgeConfig, options) => {
+			if (options.platform === 'linux') {
+				// symlink the etcher binary from balena-etcher to balenaEtcher to ensure compatibility with the wdio suite and the old name
+				await new Promise<void>((resolve, reject) => {
+					exec(
+						`ln -s "${options.outputPaths}/balena-etcher" "${options.outputPaths}/balenaEtcher"`,
+						(err) => {
+							if (err) {
+								reject(err);
+							} else {
+								resolve();
+							}
+						},
+					);
+				});
+			}
+		},
 	},
 };
 

wdio.conf.ts

@@ -1,29 +1,5 @@
 /// <reference types="wdio-electron-service" />
 import type { Options } from '@wdio/types';
-import { join } from 'path';
-
-// For backward compatibility reason, the bundle is called `balena-etcher` on linux, and balenaEtcher on all other platforms.
-// As a result, we need to specify the binary path for linux as wdio looks for balenaEtcher.
-function serviceOptions() {
-	const appArgs: string[] = [];
-	if (process.platform === 'linux') {
-		return {
-			// custom application args
-			appArgs,
-			// path to the electron binary
-			binaryPath: join(
-				__dirname,
-				'out',
-				`balenaEtcher-linux-${process.arch}`,
-				'balena-etcher',
-			),
-		};
-	} else {
-		return {
-			appArgs,
-		};
-	}
-}
 
 export const config: Options.Testrunner = {
 	//
@@ -87,7 +63,9 @@ export const config: Options.Testrunner = {
 			browserName: 'electron',
 			// Electron service options
 			// see https://webdriver.io/docs/desktop-testing/electron/configuration/#service-options
-			'wdio:electronServiceOptions': serviceOptions(),
+			'wdio:electronServiceOptions': {
+				appArgs: [],
+			},
 		},
 	],