Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link of electron-supported-platforms in README.md #4065

Closed
wants to merge 1 commit into from

Conversation

PeterDaveHello
Copy link
Contributor

This doc has moved for a while ;)

@flowzone-app flowzone-app bot enabled auto-merge May 12, 2023 11:10
@PeterDaveHello
Copy link
Contributor Author

@Lizzieepton not sure if you can help review and merge this?

@dfunckt
Copy link
Member

dfunckt commented Jun 20, 2023

Hey @PeterDaveHello -- thanks for the PR. Etcher is currently stuck at an older Electron version so links to their docs for the supported platforms are misleading -- for example, we currently do not provide Apple Silicon builds, despite what their docs says. I'd much rather you deleted the complete Note: about supported platforms and the link -- the list of actually supported platforms is provided just above that note.

@dfunckt
Copy link
Member

dfunckt commented Jun 20, 2023

BTW, make sure to provide a Change-type with your commit message so that the PR becomes mergeable. For example, here is how to format a commit message that is acceptable by our CI:

Updated foo with bar

Change-type: patch

@dfunckt dfunckt disabled auto-merge June 20, 2023 16:25
@dfunckt
Copy link
Member

dfunckt commented Dec 22, 2023

Superseded by #4132

@dfunckt dfunckt closed this Dec 22, 2023
@PeterDaveHello
Copy link
Contributor Author

Oh, sorry that I didn't notice and revise on time, but it's good to see some updates here.

@PeterDaveHello PeterDaveHello deleted the patch-1 branch December 22, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants