Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: compile child-writer.ts as a standalone cli #4102

Merged
merged 2 commits into from
Oct 16, 2023
Merged

patch: compile child-writer.ts as a standalone cli #4102

merged 2 commits into from
Oct 16, 2023

Conversation

aethernet
Copy link
Contributor

preliminary work for an upgrade to latest electron
dehairballing the bundle

@aethernet aethernet force-pushed the aethernet/childwriter-standalone branch 4 times, most recently from 0559e04 to 2c54b9d Compare September 5, 2023 14:58
@aethernet aethernet force-pushed the aethernet/childwriter-standalone branch 3 times, most recently from 2f841a9 to 1aec7a3 Compare September 15, 2023 10:56
@aethernet aethernet force-pushed the aethernet/childwriter-standalone branch 2 times, most recently from 15f82c5 to d4fb075 Compare September 27, 2023 07:54
@aethernet aethernet force-pushed the aethernet/childwriter-standalone branch from ed89937 to 77f6c52 Compare October 16, 2023 11:56
@aethernet aethernet marked this pull request as ready for review October 16, 2023 11:58
@flowzone-app flowzone-app bot enabled auto-merge October 16, 2023 11:58
@aethernet
Copy link
Contributor Author

This work is done for now.
But shouldn't be merged until we fix macos signature.
Before doing that, we're going to move from electron-builder to electron-forge which will happen in another PR.

@aethernet aethernet mentioned this pull request Oct 16, 2023
Closed
@aethernet aethernet force-pushed the aethernet/childwriter-standalone branch from 77f6c52 to f38bca2 Compare October 16, 2023 12:49
@aethernet
Copy link
Contributor Author

LGTM

@flowzone-app flowzone-app bot merged commit 45bb29a into master Oct 16, 2023
50 checks passed
@flowzone-app flowzone-app bot deleted the aethernet/childwriter-standalone branch October 16, 2023 13:31
Rotzbua added a commit to Rotzbua/etcher that referenced this pull request Dec 17, 2023
@Rotzbua
fix: required node version
7e8f038 
min required node version was changed to v18 in balena-io#4102
@Rotzbua Rotzbua mentioned this pull request Dec 17, 2023
Closed
Rotzbua added a commit to Rotzbua/etcher that referenced this pull request Dec 17, 2023
@Rotzbua
fix: required node version
c5e17d4 
min required node version was changed to v18 in balena-io#4102
Rotzbua added a commit to Rotzbua/etcher that referenced this pull request Dec 17, 2023
@Rotzbua
fix: required node version
266ac41 
min required node version was changed to v18 in balena-io#4102

Change-type: patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aethernet