patch: fix injection of analytics key at build time #4221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched to electron-forge, we moved the injection of the analytics key to a
readPackageJson
hook.This properly injects the keys in
package.json
. Unfortunately, the import of package.json is not dynamic and is done at build time by webpack before those keys are injected.To circumvent the problem, this PR replaces the hook with a webpack
definePlugin
which will inject the key in the code at build time (it acts as a search and replace), the keys are not injected in the package.json anymore as that served no other purposes.