Mark expected floating promises with the void operator

Update @balena/lint from 7.0.2 to 7.1.1

Change-type: patch
See: balena-io/pinejs#682 (comment)

init.ts

@@ -138,8 +138,7 @@ async function onInitHooks() {
 	});
 
 	// Pre-fetch the device types and populate the cache w/o blocking the API startup
-	// eslint-disable-next-line @typescript-eslint/no-floating-promises
-	getAccessibleDeviceTypes(sbvrUtils.api.resin);
+	void getAccessibleDeviceTypes(sbvrUtils.api.resin);
 
 	await sbvrUtils.db.transaction((tx) =>
 		createAll(tx, permissionNames, auth.ROLES, auth.KEYS, {}),
@@ -257,5 +256,5 @@ const init = async () => {
 		process.exit(1);
 	}
 };
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
-init();
+
+void init();

package.json

@@ -121,7 +121,7 @@
     "validator": "^13.9.0"
   },
   "devDependencies": {
-    "@balena/lint": "^7.0.2",
+    "@balena/lint": "^7.1.1",
     "@types/chai": "^4.3.4",
     "@types/mocha": "^10.0.1",
     "@types/mockery": "^1.4.30",

src/features/device-heartbeat/index.ts

@@ -195,8 +195,7 @@ export class DeviceOnlineStateManager extends EventEmitter<{
 		});
 
 		// create the RedisMQ queue and start consuming messages...
-		// eslint-disable-next-line @typescript-eslint/no-floating-promises
-		this.rsmq
+		void this.rsmq
 			.createQueueAsync({ qname: DeviceOnlineStateManager.EXPIRED_QUEUE })
 			.catch((err) => {
 				if (err.name !== 'queueExists') {
@@ -211,8 +210,7 @@ export class DeviceOnlineStateManager extends EventEmitter<{
 	}
 
 	private setupQueueStatsEmitter(interval: number) {
-		// eslint-disable-next-line @typescript-eslint/no-floating-promises
-		setTimeout(interval, undefined, { ref: false }).then(async () => {
+		void setTimeout(interval, undefined, { ref: false }).then(async () => {
 			try {
 				const startAt = Date.now();
 				const queueAttributes = await this.rsmq.getQueueAttributesAsync({
@@ -282,8 +280,7 @@ export class DeviceOnlineStateManager extends EventEmitter<{
 
 	private consume() {
 		// pull a message from the queue...
-		// eslint-disable-next-line @typescript-eslint/no-floating-promises
-		this.rsmq
+		void this.rsmq
 			.receiveMessageAsync({
 				qname: DeviceOnlineStateManager.EXPIRED_QUEUE,
 				vt: DeviceOnlineStateManager.RSMQ_READ_TIMEOUT, // prevent other consumers seeing the same message (if any) preventing multiple API agents from processing it...
@@ -308,8 +305,7 @@ export class DeviceOnlineStateManager extends EventEmitter<{
 								deviceId,
 								DeviceOnlineStates.Timeout,
 							);
-							// eslint-disable-next-line @typescript-eslint/no-floating-promises
-							this.scheduleChangeOfStateForDevice(
+							void this.scheduleChangeOfStateForDevice(
 								deviceId,
 								await this.getDeviceOnlineState(deviceId),
 								DeviceOnlineStates.Timeout,

src/features/device-logs/lib/backends/redis.ts

@@ -183,15 +183,12 @@ export class RedisBackend implements DeviceLogsBackend {
 		const key = this.getKey(ctx);
 		if (!this.subscriptions.listenerCount(key)) {
 			const subscribersKey = this.getKey(ctx, 'subscribers');
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			pubSub[SUBSCRIBECMD](key);
+			void pubSub[SUBSCRIBECMD](key);
 			// Increment the subscribers counter to recognize we've subscribed
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			redis.incrSubscribers(subscribersKey);
+			void redis.incrSubscribers(subscribersKey);
 			// Start a heartbeat to ensure the subscribers counter stays alive whilst we're subscribed
 			this.subscriptionHeartbeats[key] = setInterval(() => {
-				// eslint-disable-next-line @typescript-eslint/no-floating-promises
-				redis.expire(subscribersKey, LOGS_SUBSCRIPTION_EXPIRY_SECONDS);
+				void redis.expire(subscribersKey, LOGS_SUBSCRIPTION_EXPIRY_SECONDS);
 			}, LOGS_SUBSCRIPTION_EXPIRY_HEARTBEAT_SECONDS);
 		}
 		this.subscriptions.on(key, subscription);
@@ -205,17 +202,15 @@ export class RedisBackend implements DeviceLogsBackend {
 			// Clear the heartbeat
 			clearInterval(this.subscriptionHeartbeats[key]);
 			// And decrement the subscribers counter
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			redis.decrSubscribers(subscribersKey).then((n) => {
+			void redis.decrSubscribers(subscribersKey).then((n) => {
 				if (n < 0) {
 					captureException(
 						new Error(),
 						`Decremented logs subscribers below 0, n: '${n}', uuid: '${ctx.uuid}'`,
 					);
 				}
 			});
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			pubSub[UNSUBSCRIBECMD](key);
+			void pubSub[UNSUBSCRIBECMD](key);
 		}
 	}
 

src/features/device-provisioning/hooks/cache-invalidation.ts

@@ -31,8 +31,7 @@ const setupCacheInvalidation = <K extends string>(
 			tx.on('end', () => {
 				for (const affectedItem of affectedItems) {
 					// Run in the background as this is not a reason to fail the request
-					// eslint-disable-next-line @typescript-eslint/no-floating-promises
-					(async () => {
+					void (async () => {
 						try {
 							await cache.delete(affectedItem[keyProperty]);
 						} catch (err) {

src/features/device-provisioning/register.ts

@@ -71,8 +71,7 @@ export const register: RequestHandler = async (req, res) => {
 			// TODO: Replace this manual rollback on request closure with a more generic/automated version
 			onFinished(res, () => {
 				if (!tx.isClosed()) {
-					// eslint-disable-next-line @typescript-eslint/no-floating-promises
-					tx.rollback();
+					void tx.rollback();
 				}
 			});
 
@@ -107,8 +106,7 @@ export const register: RequestHandler = async (req, res) => {
 
 		// Clear the device existence cache for the just registered device
 		// in case it tried to communicate with the API before registering
-		// eslint-disable-next-line @typescript-eslint/no-floating-promises
-		checkDeviceExistsIsFrozen.delete(response.uuid);
+		void checkDeviceExistsIsFrozen.delete(response.uuid);
 
 		res.status(201).json(response);
 	} catch (err) {

src/features/device-types/hooks/device-types-cache-invalidation.ts

@@ -5,8 +5,7 @@ hooks.addPureHook('POST', 'resin', 'application', {
 	POSTRUN: async ({ request }) => {
 		if (request.values.is_host) {
 			// no need to wait for the cache invalidation
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			getDeviceTypes.delete();
+			void getDeviceTypes.delete();
 		}
 	},
 });
@@ -16,8 +15,7 @@ hooks.addPureHook('PATCH', 'resin', 'application', {
 		const affectedIds = request.affectedIds!;
 		if (request.values.is_host && affectedIds.length !== 0) {
 			// no need to wait for the cache invalidation
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			getDeviceTypes.delete();
+			void getDeviceTypes.delete();
 		}
 	},
 });

test/13_loki-backend.ts

@@ -99,8 +99,7 @@ describe('loki backend', () => {
 		const loki = new LokiBackend();
 		const log = createLog();
 		const incomingLog = await new Bluebird(async (resolve) => {
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			loki.subscribe(ctx, resolve);
+			void loki.subscribe(ctx, resolve);
 			await setTimeout(100); // wait for the subscription to connect
 			await loki.publish(ctx, [_.clone(log)]);
 		}).timeout(5000, 'Subscription did not receive log');
@@ -112,8 +111,7 @@ describe('loki backend', () => {
 		const loki = new LokiBackend();
 		await new Bluebird(async (resolve) => {
 			let countLogs = 0;
-			// eslint-disable-next-line @typescript-eslint/no-floating-promises
-			loki.subscribe(ctx, () => {
+			void loki.subscribe(ctx, () => {
 				countLogs += 1;
 				if (countLogs === 5) {
 					resolve();