Move to cache-manager-ioredis-yet

Depends-on: https://github.com/node-cache-manager/node-cache-manager-ioredis-yet/pull/9
Signed-off-by: Thodoris Greasidis <[email protected]>

package.json

@@ -39,8 +39,6 @@
     "@sentry/node": "^7.12.1",
     "@types/basic-auth": "^1.1.3",
     "@types/bluebird": "^3.5.36",
-    "@types/cache-manager": "^4.0.2",
-    "@types/cache-manager-ioredis": "^2.0.2",
     "@types/common-tags": "^1.8.1",
     "@types/compressible": "^2.0.0",
     "@types/compression-next": "^1.0.0",
@@ -75,7 +73,7 @@
     "bluebird": "^3.7.2",
     "body-parser": "^1.20.0",
     "cache-manager": "^5.0.0",
-    "cache-manager-ioredis": "^2.1.0",
+    "cache-manager-ioredis-yet": "^1.0.0",
     "common-tags": "^1.8.2",
     "compressible": "^2.0.18",
     "compression": "^1.7.4",

src/infra/cache/multi-level-memoizee.ts

@@ -104,7 +104,7 @@ export function multiCacheMemoizee<
 	};
 
 	const multiCacheOpts: Parameters<typeof createMultiLevelStore>[1] = {
-		default: { ...convertToMultiStoreOpts(opts), isCacheableValue: () => true },
+		default: { ...convertToMultiStoreOpts(opts), isCacheable: () => true },
 		global: convertToMultiStoreOpts({ ...opts, ...sharedCacheOpts }),
 	};
 
@@ -146,7 +146,16 @@ function multiCache<T extends (...args: any[]) => Promise<Defined | undefined>>(
 			const valueToCache = await fn(...args);
 			// Some caches (eg redis) cannot handle caching undefined/null so we convert it to the `undefinedAs` proxy value
 			// which will be used when storing in the cache and then convert it back to undefined when retrieving from the cache
-			return valueToCache === undefined ? undefinedAs : valueToCache;
+			if (valueToCache === undefined) {
+				// Just to make TS happy, since the typings should already be protecting us.
+				if (undefinedAs === undefined) {
+					throw new Error(
+						'Multilevel cache detected undefined value while the undefinedAs was not defined',
+					);
+				}
+				return undefinedAs;
+			}
+			return valueToCache;
 		});
 		return valueFromCache === undefinedAs ? undefined : valueFromCache;
 	};