Rate limit getting device logs #1430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisehara
force-pushed
the
fisehara/rate-limit-device-logs-stream
branch
from
36dc682 to
972a1a6
Compare
joshbwlng
reviewed
Sep 15, 2023
joshbwlng
reviewed
Sep 15, 2023
joshbwlng
reviewed
Sep 15, 2023
joshbwlng
reviewed
Sep 15, 2023
joshbwlng
reviewed
Sep 15, 2023
fisehara
force-pushed
the
fisehara/rate-limit-device-logs-stream
branch
from
972a1a6 to
f31e616
Compare
Opening a device logs stream or retrieving restfull device logs is not rate limited. Rate limiter distinguishes between stream and document Change-type: minor Signed-off-by: Harald Fischer <[email protected]>
fisehara
force-pushed
the
fisehara/rate-limit-device-logs-stream
branch
from
f31e616 to
b2dc7f3
Compare
Page-
requested changes
Sep 15, 2023
| fieldFn = (req) => | ||
| fields | ||
| .map((field) => { | ||
| const path = _.toPath(field); |
There was a problem hiding this comment.
This _.toPath must occur only once in the setup phase as it is fairly costly when in very hot code (eg in rate limiting code that potentially runs for every request). If we didn't care about pre-calculating the path in order to do it only once then we would instead do _.get(req, field); and let lodash do it automatically each time
|
Rate limiter is in place, during tests rate limiting is intentionally relaxed. Which enforcing strict rate limiting the endpoints get limited, generously but limited. |
auto-merge was automatically disabled
September 27, 2023 15:24
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a device logs stream or retrieving restfull device logs is not rate limited.
Rate limiter distinguishes between stream and document
Change-type: minor