Fix handling of release / contract param as string (Fixes #1427) #1468
Conversation
|
@Page- would be amazing if this PR could be merged rather than needing to change balena-cli locally after each new release |
|
@dcaputo-harmoni - Can you rebase and force push this to get past the Flowzone rebase vs merge check? |
dcaputo-harmoni
force-pushed
the
fix-json-parsing-of-release-contracts
branch
from
4f14452 to
e3473ae
Compare
|
@shaunco just did that (I think?) - let me know if you are able to approve it. |
Enables row narrowing when the rule is triggered by application changes, but more importantly allows bC to rewrite the rule using a GROUP BY. Also reduces slightly the full rule runtime from ~200ms to ~180ms. Change-type: patch See: https://explain.dalibo.com/plan/978hb14b2dd56ccb See: https://explain.dalibo.com/plan/6f1hd8f4ee0ada6d
Update @balena/abstract-sql-compiler from 8.4.1 to 9.0.2 Update @balena/pinejs from 14.62.9 to 15.0.0 Change-type: major
Update balena/open-balena-base from 14.9.1 to 14.9.3 Change-type: patch
Update grafana/loki from 2.8.1 to 2.8.2 Change-type: patch
Change-type: patch Signed-off-by: Harald Fischer <[email protected]> Signed-off-by: fisehara <[email protected]>
Update balena/open-balena-base from 14.9.3 to 14.9.4 Change-type: patch
Change-type: patch
Change-type: patch
Update balena/open-balena-base from 14.9.4 to 14.10.0 Change-type: minor
Change-type: major
Change-type: patch Signed-off-by: Thodoris Greasidis <[email protected]>
Update Change-type: patch
Update @balena/pinejs from 15.3.13 to 15.3.17 Change-type: patch Signed-off-by: Harald Fischer <[email protected]>
Update rate-limiter-flexible from 2.4.2 to 3.0.4 Change-type: patch
Update balena/open-balena-base from 16.0.13 to 16.0.15 Change-type: patch
Change-type: minor Signed-off-by: fisehara <[email protected]>
Change-type: patch
Update @balena/pinejs from 15.3.17 to 15.3.28 Change-type: patch
Update balena/open-balena-base from 16.0.15 to 16.0.16 Change-type: patch
Update balena/open-balena-base from 16.0.16 to 16.0.17 Change-type: patch
Update grafana/loki from 2.9.2 to 2.9.3 Change-type: patch
Change-type: patch
dcaputo-harmoni
force-pushed
the
fix-json-parsing-of-release-contracts
branch
from
e3473ae to
bb9254f
Compare
Unfortunately, I can't, but getting all green checks will help. |
Looks like the rebase went wrong here... should only be showing a single file changed rather than 121 files changed |
|
I have tried so many times to get PR's through to the open-balena repos with no luck. Feel free to re submit this change under a new PR if you know how to do it. |
|
@dcaputo-harmoni - If you add me as a maintainer to your temporary https://github.com/dcaputo-harmoni/open-balena-api repo, I can get it fixed and force pushed back to this same PR to hopefully get the balena crew to accept it. |
|
Hey @shaunco @dcaputo-harmoni just to let you both know this should be covered by #1501 which adds a much better compatibility layer with the released v6 that is available on balena-cloud and should cover both this and other incompatibilities between v6 and the latest unversioned api |
|
This should be handled correctly as of v14.17.0 |
Change-type: patch