device management 1: Add 'is pinned on-release' column and synchronize values from 'should be running release' #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
reviewed
May 16, 2024
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
7 times, most recently
from
1deaafb to
8207171
Compare
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
from
8207171 to
4f7db04
Compare
thgreasi
reviewed
May 28, 2024
thgreasi
reviewed
May 28, 2024
thgreasi
reviewed
May 28, 2024
src/balena-init.sql
Outdated
| CREATE INDEX IF NOT EXISTS "device_should_be_running_release_application_idx" | ||
| ON "device" ("should be running-release", "belongs to-application"); | ||
| CREATE INDEX IF NOT EXISTS "device_should_be_operated_by_release_device_type_idx" | ||
| ON "device" ("should be operated by-release", "is of-device type"); | ||
| -- Also optimizes the supervisor cpu arch should match device cpu arch rule | ||
| CREATE INDEX IF NOT EXISTS "device_should_be_managed_by__release_device_type_idx" | ||
| ON "device" ("should be managed by-release", "is of-device type"); | ||
| -- Also optimizes is pinned on successful release rule | ||
| CREATE INDEX IF NOT EXISTS "device_is_pinned_on_release_idx" |
There was a problem hiding this comment.
NIT: I would move this exactly below device_should_be_running_release_application_idx and add a TODO to the latter to drop it after the migration is complete.
|
We also NEED to add a reference to the fibery project in the description (and commit). |
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
2 times, most recently
from
d71661e to
28ad9cb
Compare
thgreasi
reviewed
May 29, 2024
thgreasi
reviewed
May 29, 2024
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
4 times, most recently
from
5672de0 to
289cdf0
Compare
thgreasi
reviewed
May 29, 2024
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
from
289cdf0 to
b1e340d
Compare
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
3 times, most recently
from
7083824 to
41429ca
Compare
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
from
41429ca to
789f692
Compare
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
from
789f692 to
97ed591
Compare
auto-merge was automatically disabled
June 5, 2024 15:57
Pull request was converted to draft
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
from
97ed591 to
4c26aea
Compare
thgreasi
reviewed
Jun 5, 2024
Comment on lines
6
to
7
| CREATE INDEX IF NOT EXISTS "device_is_pinned_on_release_idx" | ||
| ON "device" ("is pinned on-release"); |
There was a problem hiding this comment.
Suggested change
| CREATE INDEX IF NOT EXISTS "device_is_pinned_on_release_idx" | |
| ON "device" ("is pinned on-release"); | |
| CREATE INDEX IF NOT EXISTS "device_is_pinned_on_release_application_idx" | |
| ON "device" ("is pinned on-release", "belongs to-application"); |
…e values from 'should be running release' Change-type: minor
JSReds
force-pushed
the
jsreds/add-device-piined-on-release
branch
from
4c26aea to
a8ed7d1
Compare
thgreasi
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: https://balena.fibery.io/Work/Project/Server-side-pagination-for-devices-Cycle-3-539
Resolves: #1101
Change-type: minor