deviceTypes: Rename and deprecate some helpers for clarity #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
commented
Sep 6, 2024
| @@ -247,8 +247,14 @@ export const release = { | |||
| addVirtualFieldsToModel: addReleaseAdditionsToModel, | |||
| }; | |||
| export const deviceTypes = { | |||
| getAccessibleDeviceTypes, | |||
| findBySlug, | |||
| // TODO: Drop me in the next major | |||
There was a problem hiding this comment.
The next major might be for example
See: #1607
thgreasi
changed the title
thgreasi
force-pushed
the
device-type-helper-renames
branch
from
00e72f6 to
157bd23
Compare
joshbwlng
approved these changes
Sep 10, 2024
thgreasi
force-pushed
the
device-type-helper-renames
branch
from
157bd23 to
8e842ae
Compare
…peJsons Change-type: minor
Change-type: minor
Change-type: patch
…eJsons Change-type: patch
thgreasi
force-pushed
the
device-type-helper-renames
branch
from
8e842ae to
71e6689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor