Tests: Wait for the minio-server to initialize before using it #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
approved these changes
Oct 8, 2024
Page-
force-pushed
the
tests-minio-delay
branch
2 times, most recently
from
c981a0b to
6dfc2bf
Compare
This should help fix flakiness we're seeing with webresources where tests fail because we try to create the bucket before the minio server has initialized and therefore it causes test failures. This also adds a `set -e` so that if the command does still fail it should fail fast rather than after trying to run all the tests, and make it clearer where the error actually originates from Change-type: patch
Page-
force-pushed
the
tests-minio-delay
branch
from
6dfc2bf to
b3dd19d
Compare
thgreasi
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help fix flakiness we're seeing with webresources where tests fail because we try to create the bucket before the minio server has initialized and therefore it causes test failures. This also adds a
set -eso that if the command does still fail it should fail fast rather than after trying to run all the tests, and make it clearer where the error actually originates fromChange-type: patch