Skip to content

Commit

Permalink
Revert "nginx.conf: Use equal values for client_body_buffer_size and …
Browse files Browse the repository at this point in the history
…client_max_body_size to avoid writing big files to disk"

Revert commit 4159eb5 due to nginx.conf already specifying a client_max_body_size that conflicts with the newly specified one.

In fact, client_max_body_size is set to `0`, disabling any limits, therefore preventing the registry from responding with 413 when a client tries to upload large layers.

This needs further investigation to determine how Docker behaves with various registry settings, but in the meantime this needs to be reverted.

Change-Type: patch
Connects-To: #8
HQ: balena-io/balena-io#1115
  • Loading branch information
dfunckt committed Dec 14, 2017
1 parent 30ec258 commit b5ca550
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions nginx.conf
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ http {
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; # Add to x-forward-for
proxy_read_timeout 900;
proxy_buffering off;
# These two should be the same or nginx will start writing
# large request bodies to temp files
client_body_buffer_size 1m;
client_max_body_size 1m;

upstream docker-registry {
server localhost:5000;
Expand Down

0 comments on commit b5ca550

Please sign in to comment.