Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades #137

Merged
5 commits merged into from
May 4, 2022
Merged

Conversation

bartversluijs
Copy link
Contributor

@bartversluijs bartversluijs commented Feb 10, 2022

I've updated the following dependencies:

  • Updated open-balena-api to 0.192.4 (minor change / environment variable changes)
  • Updated open-balena-vpn to 9.27.0 (minor change / environment variable changes)
  • Updated open-balena-registry to 2.24.2 (minor change / environment variable changes)
  • Updated open-balena-s3 to 2.13.3 (minor change)
  • Updated open-balena-db to 5.1.0 (minor change)

I've tested the changes by creating a new instance of open-balena.
The following OS's have been tested with Balena CLI 13.1.13:

  • BalenaOS v2.65.0+rev1, supervisor 12.2.11 (development & production image)
  • BalenaOS v2.80.5+rev1, supervisor 12.8.7 (development & production image)
  • BalenaOS v2.88.5+rev1, supervisor 12.11.0 (development & production image / "developmentMode": true)

What I've tested with these BalenaOS versions:

  • Provisioning with fleet
  • Downloading release from fleet
  • Update release from fleet
  • VPN tunnel -> SSH
  • Local mode

@dfunckt
Copy link
Member

dfunckt commented Feb 11, 2022

@bartversluijs open-balena-db can automatically migrate the database between major versions -- did it not work for you?

@bartversluijs
Copy link
Contributor Author

@dfunckt I saw the code, but it didn't work afaik. Do I need to initiate it manually?

I'll try it asap after your feedback if I missed something.

@dfunckt
Copy link
Member

dfunckt commented Feb 15, 2022

I think it doesn't actually work @bartversluijs. There's this line which checks for the old Postgres version to migrate from at the wrong place. It only works if migrating from an older open-balena-db release that used to store the database under $PGDATA.

It should instead also look into $PGDATA/$OLD_PG_VERSION but getting $OLD_PG_VERSION is tricky. One way to figure out the correct directory might be getting the top result from a list of directories in $PGDATA sorted by date created or modified. Feels a bit hacky but it's likely the only way.

@dfunckt
Copy link
Member

dfunckt commented Feb 15, 2022

Haven't tested it yet but this should do it: balena-io/open-balena-db#29

The image should be up in https://hub.docker.com/r/balena/open-balena-db/tags soon if you want to give it a go.

@bartversluijs
Copy link
Contributor Author

Awesome that you've invested your time to make this work! Thanks for that!

I'm planning to test this tomorrow and will let you know how it goes. If this fixes the problem, I'll edit my commit to a minor change, which would be better than a major bump imo!

@jellyfish-bot
Copy link

[mpous] This pull request has attached support thread https://jel.ly.fish/e31f9928-2697-45dc-bf94-276875ede34a

@bartversluijs
Copy link
Contributor Author

I've rebased the branch because of PR #139

@bartversluijs bartversluijs force-pushed the dependency-upgrades-1 branch from 4613863 to 0e7c2a7 Compare April 22, 2022 14:25
@ghost
Copy link

ghost commented Apr 22, 2022

Your landr site preview has been successfully deployed to https://landr-bartversluijs-repo-open-balena-preview-137.netlify.app

Deployed with Landr 9.4.17

@bartversluijs bartversluijs force-pushed the dependency-upgrades-1 branch from 0e7c2a7 to d7ac912 Compare April 22, 2022 14:28
@bartversluijs
Copy link
Contributor Author

I've updated this PR because of balena-io/open-balena-db#29, which will automatically upgrade the PostgreSQL database to version 13.

Because of this, I've changed the 'major' change type to 'minor' for the database container 🙂

Bart Versluijs added 5 commits May 3, 2022 19:49
Update open-balena-api from 0.139.0 to 0.192.4

Change-type: minor
Update open-balena-vpn from 9.17.11 to 9.27.0

Change-type: minor
Update open-balena-registry from 2.16.1 to 2.24.2

Change-type: minor
Update open-balena-s3 from 2.9.9 to 2.13.3

Change-type: minor
Update open-balena-db from 4.1.0 to 5.1.0

Change-type: minor
@bartversluijs bartversluijs force-pushed the dependency-upgrades-1 branch from d7ac912 to 8414102 Compare May 3, 2022 17:49
@bartversluijs
Copy link
Contributor Author

@dfunckt if you have time, can you take a look at this PR?
It'll update the dependencies massively and take advantage of the latest features.

Copy link
Member

@dfunckt dfunckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you so much @bartversluijs!

@ghost ghost merged commit 4cacf67 into balena-io:master May 4, 2022
@bartversluijs bartversluijs deleted the dependency-upgrades-1 branch May 6, 2022 13:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants