Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.x: Convert to ESM #848

Merged
merged 6 commits into from
Jan 10, 2025
Merged

20.x: Convert to ESM #848

merged 6 commits into from
Jan 10, 2025

Conversation

Page-
Copy link
Collaborator

@Page- Page- commented Dec 24, 2024

No description provided.

@Page- Page- requested a review from a team December 24, 2024 17:19
@Page- Page- changed the title WIP Convert to ESM WIP: Convert to ESM Dec 24, 2024
@Page- Page- force-pushed the esm branch 9 times, most recently from 617b662 to ce2a147 Compare December 30, 2024 17:57
@Page- Page- changed the title WIP: Convert to ESM Convert to ESM Dec 30, 2024
@Page- Page- force-pushed the esm branch 4 times, most recently from 36f4684 to dbdc46e Compare January 2, 2025 16:38
@Page- Page- changed the title Convert to ESM 20.x: Convert to ESM Jan 2, 2025
package.json Outdated Show resolved Hide resolved
@otaviojacobi otaviojacobi force-pushed the esm branch 2 times, most recently from 724decc to d066e76 Compare January 3, 2025 14:02
@Page- Page- force-pushed the esm branch 2 times, most recently from 7edc621 to 8834afe Compare January 6, 2025 21:57
@Page- Page- requested a review from otaviojacobi January 9, 2025 12:24
@Page- Page- marked this pull request as ready for review January 9, 2025 12:24
@Page- Page- marked this pull request as draft January 9, 2025 12:38
Change-type: patch
Page- and others added 5 commits January 10, 2025 11:34
Change-type: patch
Change-type: major
It might work but we don't actively support it/worry if it breaks

Change-type: major
@Page- Page- marked this pull request as ready for review January 10, 2025 11:46
@Page- Page- enabled auto-merge January 10, 2025 11:46
Copy link
Collaborator Author

@Page- Page- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Page- Page- requested a review from a team January 10, 2025 13:57
@Page- Page- merged commit 74ecda3 into master Jan 10, 2025
53 checks passed
@Page- Page- deleted the esm branch January 10, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants