Use keyType during key generation to create correct key type

Change-Type: patch Connects-To: #27 Signed-off-by: Andreas Fitzek <[email protected]>
balena-io · Nov 29, 2017 · 6946659 · 6946659
1 parent eac7c03
commit 6946659
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 13 deletions.
diff --git a/resin/main.go b/resin/main.go
@@ -92,10 +92,7 @@ func init() {
 		if err := viper.BindEnv("allow-env", "SSHPROXY_ALLOW_ENV"); err != nil {
 			return err
 		}
-		if err := viper.BindEnv("sentry-dsn", "SSHPROXY_SENTRY_DSN"); err != nil {
-			return err
-		}
-		return nil
+		return viper.BindEnv("sentry-dsn", "SSHPROXY_SENTRY_DSN")
 	}()
 	if err != nil {
 		log.Fatal("Initialisation failed", err)

diff --git a/sshproxy.go b/sshproxy.go
@@ -93,7 +93,7 @@ func (s *Server) addHostKey(keyType string) error {
 		}
 		// generate ssh server keys
 		log.Printf("Generating private key... (%s)", keyType)
-		err := exec.Command("ssh-keygen", "-f", keyPath, "-t", "rsa", "-N", "").Run()
+		err := exec.Command("ssh-keygen", "-f", keyPath, "-t", keyType, "-N", "").Run()
 		if err != nil {
 			return err
 		}

diff --git a/versionist.conf.js b/versionist.conf.js
@@ -1,8 +1,16 @@
-var execSync = require('child_process').execSync;
+'use strict';
 
-var getAuthor = (commitHash) => {
-  return execSync(`git show --quiet --format="%an" ${commitHash}`, { encoding: 'utf8' }).replace('\n', '');
-}
+const execSync = require('child_process').execSync;
+
+const getAuthor = (commitHash) => {
+  return execSync(`git show --quiet --format="%an" ${commitHash}`, {
+    encoding: 'utf8'
+  }).replace('\n', '');
+};
+
+const isIncrementalCommit = (changeType) => {
+  return Boolean(changeType) && changeType.trim().toLowerCase() !== 'none';
+};
 
 module.exports = {
   // This setup allows the editing and parsing of footer tags to get version and type information,
@@ -12,7 +20,7 @@ module.exports = {
   parseFooterTags: true,
   getGitReferenceFromVersion: 'v-prefix',
   incrementVersion: 'semver',
-  updateVersion: (cwd, version, cb) => { cb(); },
+  editVersion: false,
 
   // Always add the entry to the top of the Changelog, below the header.
   addEntryToChangelog: {
@@ -23,14 +31,14 @@ module.exports = {
   // Only include a commit when there is a footer tag of 'change-type'.
   // Ensures commits which do not up versions are not included.
   includeCommitWhen: (commit) => {
-    return !!commit.footer['change-type'];
+    return isIncrementalCommit(commit.footer['change-type']);
   },
 
   // Determine the type from 'change-type:' tag.
   // Should no explicit change type be made, then no changes are assumed.
   getIncrementLevelFromCommit: (commit) => {
-    if (commit.footer['change-type']) {
-      return commit.footer['change-type'].trim();
+    if (isIncrementalCommit(commit.footer['change-type'])) {
+      return commit.footer['change-type'].trim().toLowerCase();
     }
   },