Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust language reimplementation #105

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Rust language reimplementation #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,10 @@ src/public/bower_components

# VSCode
.vscode

# Generated by Cargo
# will have compiled files and executables
/target/

# These are backup files generated by rustfmt
**/*.rs.bk
30 changes: 30 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
dist: trusty
sudo: required
language: rust
cache: cargo
rust:
- nightly
- beta
- stable
before_install:
- sudo apt-get -qq update
- sudo apt-get install -yq --no-install-recommends libdbus-1-dev
install:
- type -p cargo-install-update || cargo install cargo-update
- cargo install-update -i cargo-update
- cargo install-update -i rustfmt
# If clippy is compiled towards older nightly, then force reinstall
- if [ $TRAVIS_RUST_VERSION == nightly ]; then
cargo clippy -V;
if [ $? == 0 ]; then
cargo install-update -i clippy;
else
cargo install-update -i -f clippy;
fi
fi
script:
- cargo fmt -- --write-mode=diff
- if [ $TRAVIS_RUST_VERSION == nightly ]; then
cargo clippy -- -D warnings;
fi
- cargo build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis should build for the required architectures, push to S3 and create the github releases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the docker file to always pull the latest release for the correct architecture. If this PR was merged today it would break resin-wifi-connect?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the readme. We also need to release the 2.x version with the warnings we spoke about in the arch call before this can be merged

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked on the chat about those items - the PR will go into 104-rust, not master and we will make the changes in consecutive PRs.

Loading