Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing module in InteropValidator diagnostic reporting #31525

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

azinneera
Copy link
Contributor

@azinneera azinneera commented Jul 1, 2021

Purpose

Fix missing module in InteropValidator diagnostic reporting
Fixes #30679

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@@ -70,6 +70,7 @@ public static InteropValidator getInstance(CompilerContext context) {
}

public void validate(ModuleId moduleId, CompilerBackend compilerBackend, BLangPackage bLangPackage) {
dlog.setCurrentPackageId(bLangPackage.packageID);
Copy link
Contributor

@warunalakshitha warunalakshitha Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a test for this or improve the existing test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #31539 to track writing test cases

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #31525 (ea1635c) into master (000126c) will increase coverage by 56.26%.
The diff coverage is 57.10%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #31525       +/-   ##
=============================================
+ Coverage     14.59%   70.86%   +56.26%     
- Complexity        0    38652    +38652     
=============================================
  Files            51     2863     +2812     
  Lines          1411   158272   +156861     
  Branches        219    19934    +19715     
=============================================
+ Hits            206   112155   +111949     
- Misses         1189    39570    +38381     
- Partials         16     6547     +6531     
Impacted Files Coverage Δ
...va/io/ballerina/shell/cli/BShellConfiguration.java 0.00% <0.00%> (ø)
...in/java/io/ballerina/shell/cli/BallerinaShell.java 0.00% <0.00%> (ø)
.../java/io/ballerina/shell/cli/PropertiesLoader.java 0.00% <0.00%> (ø)
...a/io/ballerina/shell/cli/ReplShellApplication.java 0.00% <0.00%> (ø)
...ava/io/ballerina/shell/cli/ShellExitException.java 0.00% <0.00%> (ø)
...n/java/io/ballerina/shell/cli/TerminalAdapter.java 0.00% <0.00%> (ø)
.../ballerina/shell/cli/handlers/AbstractCommand.java 0.00% <0.00%> (ø)
...o/ballerina/shell/cli/handlers/CommandHandler.java 0.00% <0.00%> (ø)
...io/ballerina/shell/cli/handlers/DeleteCommand.java 0.00% <0.00%> (ø)
...a/io/ballerina/shell/cli/handlers/ExitCommand.java 0.00% <0.00%> (ø)
... and 2978 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e067e...ea1635c. Read the comment docs.

@warunalakshitha warunalakshitha merged commit 1975241 into ballerina-platform:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fails with failed to load init class runtime error when using interop
2 participants