Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.10.x] - Use Java exception to notify cannot complete future twice #43699

Merged

Conversation

ravinperera00
Copy link
Contributor

Purpose

$subject

Fixes #43654

Approach

The use of the BError removes the stacktrace related information because the printStackTrace() method is overridden within the BError class. We could use a Java Exception instead to retain that information.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@ravinperera00 ravinperera00 changed the title [2201.10.x] - Use Java exception to notify cannot complete future twice [2201.10.x] - Use Java exception to notify cannot complete future twice Dec 10, 2024
@ravinperera00 ravinperera00 marked this pull request as ready for review December 10, 2024 10:43
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (2201.10.x@08131a6). Learn more about missing BASE report.
Report is 4 commits behind head on 2201.10.x.

Files with missing lines Patch % Lines
.../java/io/ballerina/runtime/internal/BalFuture.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             2201.10.x   #43699   +/-   ##
============================================
  Coverage             ?   77.30%           
  Complexity           ?    58542           
============================================
  Files                ?     3460           
  Lines                ?   220121           
  Branches             ?    28919           
============================================
  Hits                 ?   170168           
  Misses               ?    40545           
  Partials             ?     9408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@warunalakshitha warunalakshitha merged commit 320722f into ballerina-platform:2201.10.x Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants