Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.11.x] Fix support for breakpoint changes inside Ballerina services during a debug session #43740

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[2201.11.x] Fix support for breakpoint changes inside Ballerina services during a debug session #43740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .../debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/BreakpointProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,7 @@ void restoreUserBreakpoints() {
}

context.getEventManager().deleteAllBreakpoints();
for (Map.Entry<String, LinkedHashMap<Integer, BalBreakpoint>> entry : userBreakpoints.entrySet()) {
String qClassName = entry.getKey();
context.getDebuggeeVM().classesByName(qClassName).forEach(ref -> activateUserBreakPoints(ref, false));
}
context.getDebuggeeVM().allClasses().forEach(ref -> activateUserBreakPoints(ref, false));
}

/**
Expand Down
3 changes: 1 addition & 2 deletions ...es/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JDIEventProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,7 @@

// Setting breakpoints to an already running debug session.
context.getEventManager().deleteAllBreakpoints();
context.getDebuggeeVM().classesByName(qClassName)
.forEach(ref -> breakpointProcessor.activateUserBreakPoints(ref, false));
context.getDebuggeeVM().allClasses().forEach(ref -> breakpointProcessor.activateUserBreakPoints(ref, false));

Check warning on line 178 in misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JDIEventProcessor.java

View check run for this annotation

Codecov / codecov/patch

misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JDIEventProcessor.java#L178 

Added line #L178 was not covered by tests
}

void sendStepRequest(int threadId, int stepType) {
Expand Down
Loading