Add spec conformance tests for Floating-point-literal #947

suleka96 · 2021-10-04T04:42:23Z

Purpose

$title

Related lang issue #32474

conformance/lang/expressions/literals/floating_point_literal.balt

pcnfernando · 2021-10-12T14:52:52Z

There are failing test cases against the test runner.

hasithaa · 2021-12-06T16:19:43Z

The Team is busy with finalizing the SwanLake GA release. Hence closing this PR temporarily.

…ina-spec into floatingpoint

conformance/lang/expressions/literals/floating_point_literal.balt

KavinduZoysa · 2023-02-23T14:50:55Z

Let's add test cases for HexFloatingPointLiteral, that are combined(appended to hex value) with p, P, d, D, f, F.

KavinduZoysa · 2023-02-23T14:55:32Z

There should have test cases for,

NaN, infinities and subnormals are not supported; operations that would result in one of these values according to the normal rules of IEEE 754-2008 instead result in a panic.
rounding on float and decimal
Using NaN is float

KavinduZoysa · 2023-02-23T14:56:56Z

Do we have test cases for this
Thus two decimal values have the same shape if they represent the same mathematical value, even if they do so using different exponents?

conformance/lang/expressions/literals/floating_point_literal.balt

MaryamZi · 2023-03-10T10:44:20Z

conformance/lang/expressions/literals/floating_point_literal.balt

+}
+
+Test-Case: output
+Description: Test HexFloatingPointLiteral with toString().


What's the reason to add toString tests specifically?

was added when when we first wrote the tests to see if the output was correct, like if it has the correct number of zero digits after the decimal point and so on.

conformance/lang/expressions/literals/floating_point_literal.balt

suleka96 · 2023-03-15T04:35:20Z

@KavinduZoysa regarding :

Let's add test cases for HexFloatingPointLiteral, that are combined(appended to hex value) with p, P, d, D, f, F.

those tests are already there in: Test invalid hex floating point literal

conformance/lang/expressions/literals/floating_point_literal.balt

MaryamZi · 2023-04-04T05:50:40Z

conformance/lang/expressions/literals/floating_point_literal.balt

+    g = 56763457;
+    io:println(g); // @output 56763457
+
+    g = 0d;


Any reason to not split these tests similar to float above?

MaryamZi · 2023-04-04T05:55:45Z

conformance/lang/expressions/literals/floating_point_literal.balt

+Description: Test out of range decimal floating point literal with decimal type descriptor.
+Labels: decimal
+
+function init() {
+    decimal a = 9.99E+6111;
+    io:println(a); // @output 9.99E+6111


Is this output correct if out of range? cc @KavinduZoysa

MaryamZi · 2023-04-04T06:11:50Z

conformance/lang/expressions/literals/floating_point_literal.balt

+
+}
+
+function printDecimalFloatingPoint1() returns float|decimal {


We don't have to change here, but taking this as an example for future tests, we can make tests simpler by avoiding testing the same thing over and over again.

We've already tested different literals against float|decimal, so we don't have to test in every context. Just one or two would be enough.

MaryamZi · 2023-04-04T06:14:23Z

conformance/lang/expressions/literals/floating_point_literal.balt

+}
+
+Test-Case: output
+Description: Test the basic type when the applicable contextually expected type is a subtype of float, having a union with nil and float types.


OK to keep, but why were these tests added? What exactly was the special scenario we wanted to test?

MaryamZi · 2023-04-04T06:15:48Z

conformance/lang/expressions/literals/floating_point_literal.balt

+    io:println(x is float);
+    io:println(x is int);
+    io:println(x is decimal);


Why not in order int, float, decimal? Or at least float, decimal, int.

MaryamZi · 2023-04-04T06:17:01Z

conformance/lang/expressions/literals/floating_point_literal.balt

+Description: Test rounding floating point values with float type.
+Labels: float, FloatingPointTypeSuffix, HexFloatingPointLiteral
+
+function init() {
+    float c = float:round(0.001234, 2);


Why were these tests added? These are float (and decimal) langlib tests.

MaryamZi · 2023-04-04T06:18:33Z

conformance/lang/expressions/literals/floating_point_literal.balt

+}
+
+Test-Case: error
+Description: Test hex indicator with float type descriptor.


Doesn't properly describe the test?

MaryamZi · 2023-04-04T06:19:15Z

conformance/lang/expressions/literals/floating_point_literal.balt

+Labels: decimal, HexFloatingPointLiteral
+
+function errorFunction() {
+    decimal _ = 0x1.0fp+10; // @error hex floating point literal is incompatible  with 'decimal'


incompatible -> not allowed

MaryamZi · 2023-04-04T06:19:34Z

conformance/lang/expressions/literals/floating_point_literal.balt

+function init() {
+    float|decimal a = 0x1.0;
+
+    if (a is decimal) {


Suggested change

if (a is decimal) {

if a is decimal {

MaryamZi · 2023-04-04T06:20:47Z

conformance/lang/expressions/literals/floating_point_literal.balt

+}
+
+Test-Case: output
+Description: Test hex floating point literal type narrowing with floating point type descriptor.


Type narrowing is on the variable, not the literal. Can we update this to say narrowing when a literal is used with the union of float and decimal instead?

Add floating point tests

053d39c

suleka96 requested review from hasithaa, MaryamZi, rdhananjaya and sameerajayasoma as code owners October 4, 2021 04:42

suleka96 changed the title ~~Add floating point tests~~ Add spec conformance tests for Floating-point-literal Oct 4, 2021

gimantha requested review from SandaruJayawardana and pcnfernando October 4, 2021 05:22

SandaruJayawardana reviewed Oct 11, 2021

View reviewed changes

pcnfernando requested changes Oct 12, 2021

View reviewed changes

hasithaa closed this Dec 6, 2021

suleka96 reopened this Jan 20, 2023

suleka96 added 3 commits January 20, 2023 10:41

Merge branch 'master' of https://github.com/ballerina-platform/baller…

a200e48

…ina-spec into floatingpoint

Update all tests to match the current implementation

808331d

add out of range float test

e6737e2

suleka96 changed the base branch from conformance-tests to master February 21, 2023 10:33

MaryamZi requested review from pcnfernando, chiranSachintha, dulajdilshan and KavinduZoysa February 21, 2023 10:49

KavinduZoysa reviewed Feb 23, 2023

View reviewed changes

conformance/lang/expressions/literals/floating_point_literal.balt Outdated Show resolved Hide resolved

MaryamZi reviewed Mar 10, 2023

View reviewed changes

Update tests

88661c0

MaryamZi requested a review from KavinduZoysa March 24, 2023 05:57

pcnfernando reviewed Mar 24, 2023

View reviewed changes

conformance/lang/expressions/literals/floating_point_literal.balt Show resolved Hide resolved

pcnfernando reviewed Mar 24, 2023

View reviewed changes

conformance/lang/expressions/literals/floating_point_literal.balt Show resolved Hide resolved

Update tests

7bdcae0

MaryamZi requested review from pcnfernando and MaryamZi April 4, 2023 05:05

MaryamZi reviewed Apr 4, 2023

View reviewed changes

hasithaa closed this Jul 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add spec conformance tests for Floating-point-literal #947

Add spec conformance tests for Floating-point-literal #947

suleka96 commented Oct 4, 2021

pcnfernando commented Oct 12, 2021

hasithaa commented Dec 6, 2021

KavinduZoysa commented Feb 23, 2023

KavinduZoysa commented Feb 23, 2023

KavinduZoysa commented Feb 23, 2023

MaryamZi Mar 10, 2023

suleka96 Mar 22, 2023

suleka96 commented Mar 15, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023

MaryamZi Apr 4, 2023


		}

		function printDecimalFloatingPoint1() returns float\|decimal {

Add spec conformance tests for Floating-point-literal #947

Add spec conformance tests for Floating-point-literal #947

Conversation

suleka96 commented Oct 4, 2021

Purpose

pcnfernando commented Oct 12, 2021

hasithaa commented Dec 6, 2021

KavinduZoysa commented Feb 23, 2023

KavinduZoysa commented Feb 23, 2023

KavinduZoysa commented Feb 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

suleka96 commented Mar 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment