Exclude spotbugs to avoid reinitiating field values

ballerina-platform · May 13, 2024 · 6205b51 · 6205b51
1 parent 6197f36
commit 6205b51
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 8 deletions.
diff --git a/build-config/spotbugs-exclude.xml b/build-config/spotbugs-exclude.xml
@@ -26,7 +26,21 @@
         <Method name = "visit" />
         <Bug pattern="BC_UNCONFIRMED_CAST" />
     </Match>
+    <Match>
         <Class name="io.ballerina.lib.avro.deserialize.visitor.DeserializeVisitor" />
         <Method name = "extractMapType" />
         <Bug pattern="BC_UNCONFIRMED_CAST" />
+    </Match>
+    <Match>
+        <Class name="io.ballerina.lib.avro.deserialize.Deserializer" />
+        <Bug pattern="EI_EXPOSE_REP" />
+    </Match>
+    <Match>
+        <Class name="io.ballerina.lib.avro.serialize.Serializer" />
+        <Bug pattern="EI_EXPOSE_REP" />
+    </Match>
+    <Match>
+        <Class name="io.ballerina.lib.avro.serialize.Serializer" />
+        <Bug pattern="EI_EXPOSE_REP2" />
+    </Match>
 </FindBugsFilter>
diff --git a/native/src/main/java/io/ballerina/lib/avro/deserialize/Deserializer.java b/native/src/main/java/io/ballerina/lib/avro/deserialize/Deserializer.java
@@ -34,16 +34,16 @@ public Deserializer() {
     }
 
     public Deserializer(Type type, Schema schema) {
-        this.schema = schema == null ? null : new Schema.Parser().parse(schema.toString());
+        this.schema = schema == null ? null : schema;
         this.type = type == null ? null : TypeUtils.getReferredType(type);
     }
 
     public Schema getSchema() {
-        return new Schema.Parser().parse(schema.toString());
+        return this.schema;
     }
 
     public Type getType() {
-        return TypeUtils.getReferredType(type);
+        return this.type;
     }
 
     public abstract Object accept(DeserializeVisitor visitor, Object data) throws Exception;

diff --git a/native/src/main/java/io/ballerina/lib/avro/serialize/Serializer.java b/native/src/main/java/io/ballerina/lib/avro/serialize/Serializer.java
@@ -25,7 +25,7 @@
 
 public abstract class Serializer {
 
-    private final String schema;
+    private final Schema schema;
     private final Type type;
 
     public Serializer() {
@@ -35,20 +35,20 @@ public Serializer() {
 
     public Serializer(Schema schema) {
         this.type = null;
-        this.schema = schema.toString();
+        this.schema = schema;
     }
 
     public Serializer(Schema schema, Type type) {
         this.type = TypeUtils.getImpliedType(type);
-        this.schema = schema.toString();
+        this.schema = schema;
     }
 
     public Schema getSchema() {
-        return new Schema.Parser().parse(schema);
+        return this.schema;
     }
 
     public Type getType() {
-        return TypeUtils.getImpliedType(type);
+        return this.type;
     }
 
     public abstract Object convert(SerializeVisitor serializeVisitor, Object data) throws Exception;