Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bouncy Castle version #532

Closed

Conversation

MohamedSabthar
Copy link
Member

@MohamedSabthar MohamedSabthar commented Oct 20, 2023

Purpose

Related to: ballerina-platform/ballerina-library#4776

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ayeshLK
Copy link
Member

ayeshLK commented Oct 20, 2023

@MohamedSabthar don't we hv to bump a minor version ?

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2201.0.x@e6e83e3). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff             @@
##             2201.0.x     #532   +/-   ##
===========================================
  Coverage            ?   85.90%           
  Complexity          ?       76           
===========================================
  Files               ?       15           
  Lines               ?      383           
  Branches            ?       56           
===========================================
  Hits                ?      329           
  Misses              ?       43           
  Partials            ?       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohamedSabthar MohamedSabthar marked this pull request as draft October 20, 2023 05:05
@TharmiganK
Copy link
Contributor

Lets not merge this, since this version of crypto is compatible from 0.x. Since we are only giving patches for http, grpc with 2.x, other version builds will give a conflicting jar warning.

@TharmiganK TharmiganK closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants