-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new APIs to read EC private keys and public keys #533
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
============================================
+ Coverage 86.25% 87.52% +1.27%
- Complexity 76 93 +17
============================================
Files 16 16
Lines 422 465 +43
Branches 56 65 +9
============================================
+ Hits 364 407 +43
Misses 47 47
Partials 11 11 ☔ View full report in Codecov by Sentry. |
e80fe97
to
b854d9f
Compare
native/src/main/java/io/ballerina/stdlib/crypto/nativeimpl/Decode.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/crypto/nativeimpl/Decode.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/crypto/nativeimpl/Decode.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
This PR is to introduce 4 new APIs to the Crypto module to interact with the private keys and public keys signed with "EC" algorithms.
Fixes: ballerina-platform/ballerina-library#5821
Examples
Newly introduced APIs,
Decode a 'EC' private key
Decode a 'EC' public key
Generate a SHA384withECDSA based signature
Verify a SHA384withECDSA based signature
Checklist