Fix CCE in arrays with refered types

ballerina-platform · Aug 20, 2024 · b251984 · b251984
1 parent b049daa
commit b251984
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/ballerina/tests/fromXml_test.bal b/ballerina/tests/fromXml_test.bal
@@ -3585,3 +3585,26 @@ isolated function testDuplicateField() {
     test:assertTrue(err4 is Error);
     test:assertEquals((<Error> err4).message(), "duplicate field 'name'");
 }
+
+type Ports record {|
+    PortContent[] port;
+|};
+
+@Namespace {
+    prefix: "ns1",
+    uri: "example1.com"
+}
+type PortContent record {|
+    string \#content; 
+|};
+
+@test:Config
+isolated function testTypeRefArray() {
+    string s = string `
+        <A xmlns:ns1="example1.com" xmlns:ns2="example2.com">
+            <ns1:port>1</ns1:port>
+            <ns1:port>1</ns1:port>
+        </A>`;
+    Ports|error rec = parseString(s);
+    test:assertEquals(rec, {"port":[{"#content":"1"},{"#content":"1"}]});
+}
diff --git a/native/src/main/java/io/ballerina/lib/data/xmldata/xml/XmlParser.java b/native/src/main/java/io/ballerina/lib/data/xmldata/xml/XmlParser.java
@@ -357,9 +357,10 @@ private void convertTextAndUpdateCurrentNode(BMap<BString, Object> currentNode,
     @SuppressWarnings("unchecked")
     private void addTextToCurrentNodeIfExpTypeIsArray(ArrayType fieldType, BString bFieldName, BString bText,
                                                       XmlParserData xmlParserData) {
-        int elementTypeTag = TypeUtils.getReferredType(fieldType.getElementType()).getTag();
+        Type referredType = TypeUtils.getReferredType(fieldType.getElementType());
+        int elementTypeTag = referredType.getTag();
         switch (elementTypeTag) {
-            case TypeTags.RECORD_TYPE_TAG -> handleContentFieldInRecordType((RecordType) fieldType.getElementType(),
+            case TypeTags.RECORD_TYPE_TAG -> handleContentFieldInRecordType((RecordType) referredType,
                     bText, xmlParserData);
             case TypeTags.ANYDATA_TAG, TypeTags.JSON_TAG -> {
                 BArray tempArr = (BArray) ((BMap<BString, Object>) xmlParserData.nodesStack.peek()).get(bFieldName);