Add constraint validation #21
Conversation
native/src/main/java/io/ballerina/lib/data/xmldata/xml/Native.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
============================================
- Coverage 87.13% 86.66% -0.48%
- Complexity 468 512 +44
============================================
Files 21 22 +1
Lines 2083 2234 +151
Branches 462 495 +33
============================================
+ Hits 1815 1936 +121
- Misses 162 173 +11
- Partials 106 125 +19 ☔ View full report in Codecov by Sentry. |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
@prakanth97 PR contains conflicts |
|
|
||
| public static final MapType JSON_MAP_TYPE = TypeCreator.createMapType(PredefinedTypes.TYPE_JSON); | ||
| public static final ArrayType JSON_ARRAY_TYPE = TypeCreator.createArrayType(PredefinedTypes.TYPE_JSON); | ||
| public static final QualifiedName EXIT_REST_POINT = new QualifiedName("", "$exitRestPoint$", ""); |
There was a problem hiding this comment.
what is the use of this constant?
There was a problem hiding this comment.
Assume following expected type,
type A record {|
record {|
record {|
json...;
|}...;
|}...;
|};
We used this to exit from each rest type scope.
How we handle the rest type is wrong. I have fix this in this PR https://github.com/ballerina-platform/module-ballerina-data.xmldata/pull/26/files#diff-ad9f60570df671743210dd195978175e7b8fd93b1ad5dff8f112a158d3a3ba5a where this is not required hence removed EXIT_REST_POINT constant.
There was a problem hiding this comment.
This is not introduced in this PR, I just rearranged the constants.
Purpose
Fixes: #6559
Examples
Checklist