-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile-time error logging for user defined module prefix for xmldata #22
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e60d6e9
[Automated] Update the native jar versions
prakanth97 97dc5ec
Fix error logging for user defined module prefix
prakanth97 5430f78
Add more tests for user defined import prefix
prakanth97 17a279e
Reset xmldata record type validator attributes
prakanth97 79dd70a
Merge branch 'main' into issue_6540
hasithaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
compiler-plugin-test/src/test/resources/ballerina_sources/sample_package_11/Ballerina.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
[package] | ||
org = "xmldata_test" | ||
name = "sample_11" | ||
version = "0.1.0" |
8 changes: 8 additions & 0 deletions
8
compiler-plugin-test/src/test/resources/ballerina_sources/sample_package_11/main.bal
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import ballerina/data.xmldata as xd; | ||
|
||
type UnionType record {|int a;|}|record {|string b;|}; | ||
|
||
public function main() returns error? { | ||
string str = string `{"a": 1, "b": "str"}`; | ||
UnionType _ = check xd:parseString(str); | ||
} |
4 changes: 4 additions & 0 deletions
4
compiler-plugin-test/src/test/resources/ballerina_sources/sample_package_12/Ballerina.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
[package] | ||
org = "xmldata_test" | ||
name = "sample_12" | ||
version = "0.1.0" |
6 changes: 6 additions & 0 deletions
6
compiler-plugin-test/src/test/resources/ballerina_sources/sample_package_12/file_1.bal
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import ballerina/data.xmldata as xd; | ||
|
||
public function testFunc() returns error? { | ||
string str = string `{"a": 1, "b": "str"}`; | ||
UnionType _ = check xd:parseString(str); | ||
} |
6 changes: 6 additions & 0 deletions
6
compiler-plugin-test/src/test/resources/ballerina_sources/sample_package_12/file_2.bal
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import ballerina/data.xmldata as xd2; | ||
|
||
public function testFunc2() returns error? { | ||
string str = string `{"a": 1, "b": "str"}`; | ||
UnionType _ = check xd2:parseString(str); | ||
} |
6 changes: 6 additions & 0 deletions
6
compiler-plugin-test/src/test/resources/ballerina_sources/sample_package_12/file_3.bal
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import ballerina/data.xmldata; | ||
|
||
public function testFunc3() returns error? { | ||
string str = string `{"a": 1, "b": "str"}`; | ||
UnionType _ = check xmldata:parseString(str); | ||
} |
1 change: 1 addition & 0 deletions
1
compiler-plugin-test/src/test/resources/ballerina_sources/sample_package_12/types.bal
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
type UnionType record {|int a;|}|record {|string b;|}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another file with a different prefix and another file with default. Use file names as m1 -> prefix: xd , m2 -> no prefix, m3-> prefix: xd2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test 9d60c4b52292821340dd8a4787c1639b44dac0a1