Fix name annotation lookup logic and handle union as member type of array value #25
Conversation
There was a problem hiding this comment.
@prakanth97 I don't see any test source changes along with the fix, so I assume this is something we've missed to cover in the module's test suite.
So wouldn't it be better to add a test case to cover the fixed scenario?
prakanth97
changed the title
| record.put(bKeyName, ValueCreator.createArrayValue(value.toArray(), | ||
| TypeCreator.createArrayType(Constants.JSON_ARRAY_TYPE))); | ||
| } | ||
| } |
There was a problem hiding this comment.
I guess we need to handle element being a Intersection scenario as well.
| @Namespace {prefix: "ex1", uri: "example1.com"} | ||
| type Ex1_Reply record { | ||
| @Namespace {prefix: "ex1", uri: "example1.com"} | ||
| string Address; |
There was a problem hiding this comment.
Shall we add a another test where this attribute being another record?
| for (int i = 0; i < arrayValue.getLength(); i++) { | ||
| Object element = arrayValue.get(i); | ||
| Type actualElementType = getTypeFromUnionType(elementType, element); | ||
| if (actualElementType.getTag() == TypeTags.RECORD_TYPE_TAG) { |
There was a problem hiding this comment.
if the expected type is TypeTags.MAP_TYPE_TAG, this behaviour should be same ryt?
|
This PR is not valid since it handles specific union type case for |
Purpose
Fixes: #6689
Examples
Checklist