-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix converting xml to record type with rest type and required fields #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR depends on #20. |
prakanth97
requested review from
gimantha,
pcnfernando,
LakshanWeerasinghe and
SasinduDilshara
July 18, 2024 06:24
native/src/main/java/io/ballerina/lib/data/xmldata/utils/DataUtils.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
============================================
+ Coverage 85.92% 86.46% +0.53%
- Complexity 524 556 +32
============================================
Files 22 25 +3
Lines 2281 2416 +135
Branches 513 529 +16
============================================
+ Hits 1960 2089 +129
+ Misses 195 187 -8
- Partials 126 140 +14 ☔ View full report in Codecov by Sentry. |
SasinduDilshara
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: #6659
In the above case issue is element
str1
is convert to anydata (int
runtime value) instead of string. This is due to the all the elements afterstr2
convert to the rest type. In this PR we have fixed this wrong behaviour.Examples
Checklist