Support options for XML conversions and Refactor apis #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge this after #5 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
============================================
- Coverage 78.25% 77.92% -0.34%
- Complexity 449 459 +10
============================================
Files 21 21
Lines 2005 2079 +74
Branches 440 458 +18
============================================
+ Hits 1569 1620 +51
- Misses 328 350 +22
- Partials 108 109 +1 ☔ View full report in Codecov by Sentry. |
native/src/main/java/io/ballerina/stdlib/data/xmldata/utils/DataUtils.java
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/data/xmldata/xml/XmlParser.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/data/xmldata/xml/XmlParser.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/data/xmldata/xml/XmlParser.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/data/xmldata/xml/XmlParser.java
Show resolved
Hide resolved
prakanth97
changed the title
hasithaa
reviewed
Mar 22, 2024
| `; | ||
| Employee|error e = parseAsType(xmlVal1, sOptions3); | ||
| test:assertTrue(e is error); | ||
| test:assertEquals((<error>e).message(), "undefined field 'age' in record 'data.xmldata:Employee'"); |
There was a problem hiding this comment.
Minor formatting issue. check other places too.
There was a problem hiding this comment.
I have updated ballerina formatting issues 08b2841
When calling the formatter, This line remain unchanged. Are you referring space between cast-expr and the identifier e?
hasithaa
approved these changes
Mar 26, 2024
prakanth97
added a commit
to prakanth97/module-ballerina-data-xmldata
that referenced
this pull request
Aug 14, 2024
Fix bug in stream_namespace_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: #6073
Examples
Checklist