Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.0.0] Fix client configuration getting overwritten when mutliple clients are available #1493

Merged
merged 8 commits into from
Dec 18, 2023

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Dec 18, 2023

Purpose

$subject
Fixes ballerina-platform/ballerina-library#5892

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi marked this pull request as ready for review December 18, 2023 11:34
@dilanSachi dilanSachi changed the title Fix client configuration getting overwritten when mutliple clients are available [2201.0.0] Fix client configuration getting overwritten when mutliple clients are available Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (647976b) 82.19% compared to head (2baf5fa) 75.80%.
Report is 6 commits behind head on 1.2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            1.2.x    #1493      +/-   ##
==========================================
- Coverage   82.19%   75.80%   -6.40%     
==========================================
  Files         128      128              
  Lines        7522     7523       +1     
  Branches     1373     1372       -1     
==========================================
- Hits         6183     5703     -480     
- Misses        889     1373     +484     
+ Partials      450      447       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dilanSachi dilanSachi merged commit 098f4cb into ballerina-platform:1.2.x Dec 18, 2023
4 of 5 checks passed
@dilanSachi dilanSachi deleted the multiconfig-u1 branch December 18, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants