Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxHeaderSize config for server side #1531

Merged
merged 12 commits into from
Feb 1, 2024

Conversation

dilanSachi
Copy link
Contributor

Purpose

$subject
Fixes ballerina-platform/ballerina-library#5969

For now, I have only added support for server side header size configuration as http2 does not support the client side yet. This is tracked in ballerina-platform/ballerina-library#5992

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

daneshk
daneshk previously approved these changes Feb 1, 2024
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (55f05ed) 80.68% compared to head (c93685e) 80.65%.

Files Patch % Lines
...ballerina/stdlib/grpc/ClientConnectorListener.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1531      +/-   ##
============================================
- Coverage     80.68%   80.65%   -0.03%     
- Complexity        0       56      +56     
============================================
  Files            76       80       +4     
  Lines          5477     5660     +183     
  Branches       1275     1322      +47     
============================================
+ Hits           4419     4565     +146     
- Misses          657      676      +19     
- Partials        401      419      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi merged commit 38cec89 into ballerina-platform:master Feb 1, 2024
7 of 8 checks passed
@dilanSachi dilanSachi deleted the header-size branch February 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ballerina-GRPC] Unable to configure header size in Ballerina gRPC server configuration
2 participants