Fix cache key generation with method

ballerina-platform · May 29, 2024 · 6a7754c · 6a7754c
1 parent e416afb
commit 6a7754c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ballerina-tests/http-advanced-tests/tests/http_cache_config_annotation_test.bal b/ballerina-tests/http-advanced-tests/tests/http_cache_config_annotation_test.bal
@@ -331,11 +331,11 @@ function testReturnStatusCodeResponsesWithAnnotation() returns error? {
 function testBasicCachingBehaviourWithExecute() returns error? {
     check checkBasicCachingBehaviourWithExecute("GET", 1);
     runtime:sleep(1);
-    check checkBasicCachingBehaviourWithExecute("get", 2);
+    check checkBasicCachingBehaviourWithExecute("get", 1);
     runtime:sleep(1);
-    check checkBasicCachingBehaviourWithExecute("HEAD", 3);
+    check checkBasicCachingBehaviourWithExecute("HEAD", 2);
     runtime:sleep(1);
-    check checkBasicCachingBehaviourWithExecute("head", 4);
+    check checkBasicCachingBehaviourWithExecute("head", 2);
 }
 
 function checkBasicCachingBehaviourWithExecute(string method, int hitCount) returns error? {

diff --git a/ballerina/caching_http_cache.bal b/ballerina/caching_http_cache.bal
@@ -194,5 +194,5 @@ isolated function weakValidatorEquals(string etag1, string etag2) returns boolea
 }
 
 isolated function getCacheKey(string httpMethod, string url) returns string {
-    return string `${httpMethod} ${url}`;
+    return string `${httpMethod.toUpperAscii()} ${url}`;
 }