Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mTLS failure when using certs and keys in HTTP2 #1773

Merged
merged 11 commits into from
Oct 9, 2023

Conversation

Bhashinee
Copy link
Member

@Bhashinee Bhashinee commented Oct 9, 2023

Purpose

Fixes: ballerina-platform/ballerina-library#4890

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (21ce4a3) 81.62% compared to head (3bbe8b4) 81.64%.
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1773      +/-   ##
============================================
+ Coverage     81.62%   81.64%   +0.01%     
  Complexity      562      562              
============================================
  Files           394      394              
  Lines         21352    21354       +2     
  Branches       4779     4780       +1     
============================================
+ Hits          17429    17434       +5     
- Misses         2937     2939       +2     
+ Partials        986      981       -5     
Files Coverage Δ
...ort/contractimpl/common/ssl/SSLHandlerFactory.java 87.36% <100.00%> (+0.14%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@Bhashinee Bhashinee marked this pull request as ready for review October 9, 2023 09:45
@Bhashinee Bhashinee merged commit f5a3323 into ballerina-platform:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants