Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some Java classes proper utilities #1790

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Oct 13, 2023

Purpose

Closes ballerina-platform/ballerina-library#4923.

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Made the design cleaner by marking Java classes as `final`
and explicitly declaring their default constructors as `private`.
This change makes the code coverage reports more accurate.
Closes #4923.
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (72832c3) 81.44% compared to head (ca80dac) 81.68%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1790      +/-   ##
============================================
+ Coverage     81.44%   81.68%   +0.23%     
- Complexity        0      562     +562     
============================================
  Files           357      393      +36     
  Lines         19603    21343    +1740     
  Branches       4434     4780     +346     
============================================
+ Hits          15966    17433    +1467     
- Misses         2794     2930     +136     
- Partials        843      980     +137     
Files Coverage Δ
...a/stdlib/http/compiler/HttpCompilerPluginUtil.java 91.79% <ø> (ø)
...ttp/compiler/HttpInterceptorResourceValidator.java 96.55% <ø> (ø)
...na/stdlib/http/compiler/HttpResourceValidator.java 84.33% <ø> (ø)
...ina/stdlib/http/compiler/codeaction/Constants.java 100.00% <ø> (ø)
...ina/stdlib/http/compiler/completion/Constants.java 100.00% <ø> (ø)
...va/io/ballerina/stdlib/http/api/HttpConstants.java 100.00% <ø> (ø)
...a/stdlib/http/api/logging/util/LogLevelMapper.java 88.88% <ø> (+4.67%) ⬆️
...dlib/http/api/nativeimpl/ExternRequestContext.java 87.50% <ø> (+1.78%) ⬆️
...lerina/stdlib/http/api/nativeimpl/ExternUtils.java 100.00% <ø> (+11.11%) ⬆️
...ort/contractimpl/common/states/Http2StateUtil.java 73.83% <ø> (+0.42%) ⬆️
... and 1 more

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vil02
Copy link
Contributor Author

vil02 commented Oct 17, 2023

@TharmiganK do you know what is the reason of PR Build / Run PR Build Workflow / Build on Windows failing? It does not seem to be related to the proposed change.

@TharmiganK
Copy link
Contributor

@TharmiganK do you know what is the reason of PR Build / Run PR Build Workflow / Build on Windows failing? It does not seem to be related to the proposed change.

It seems to be an intermittent network failure. Re-triggered the check

@vil02
Copy link
Contributor Author

vil02 commented Oct 17, 2023

Now it passed.

@TharmiganK TharmiganK merged commit 7d7bae9 into ballerina-platform:master Oct 17, 2023
@vil02 vil02 deleted the 4923_make_some_java_classes_proper_utilities branch October 17, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some of the Java classes in module-http proper utility classes
2 participants