Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IndexOutOfBoundsException exception when decoding jwt header #1823

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Fix IndexOutOfBoundsException exception when decoding jwt header #1823

merged 8 commits into from
Dec 6, 2023

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Dec 4, 2023 •
edited
Loading

Purpose

$subject
Related to ballerina-platform/ballerina-library#5856

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi added Skip GraalVM Check This will skip the GraalVM compatibility check and removed Skip GraalVM Check This will skip the GraalVM compatibility check labels Dec 4, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f937653) 81.69% compared to head (98d7bd9) 81.70%.
Report is 1 commits behind head on master.

Files Patch % Lines
...a/io/ballerina/stdlib/http/api/HttpDispatcher.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1823      +/-   ##
============================================
+ Coverage     81.69%   81.70%   +0.01%     
  Complexity      562      562              
============================================
  Files           393      393              
  Lines         21352    21354       +2     
  Branches       4783     4784       +1     
============================================
+ Hits          17443    17447       +4     
  Misses         2921     2921              
+ Partials        988      986       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi marked this pull request as ready for review December 5, 2023 04:23
@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Dec 5, 2023
@dilanSachi dilanSachi force-pushed the improve-data-binding branch from 6e27d5f to d3833f3 Compare December 5, 2023 04:28
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

TharmiganK
TharmiganK approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dilanSachi dilanSachi merged commit 45e32d8 into ballerina-platform:master Dec 6, 2023
7 of 8 checks passed
@dilanSachi dilanSachi deleted the improve-data-binding branch December 6, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TharmiganK TharmiganK TharmiganK approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

Assignees
No one assigned
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilanSachi @TharmiganK