-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the logic of GoAway frame handling in the client side #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilanSachi
added
the
Skip GraalVM Check
This will skip the GraalVM compatibility check
label
Jan 2, 2024
dilanSachi
removed
the
Skip GraalVM Check
This will skip the GraalVM compatibility check
label
Jan 8, 2024
dilanSachi
added
the
Skip GraalVM Check
This will skip the GraalVM compatibility check
label
Jan 9, 2024
dilanSachi
added
the
Skip GraalVM Check
This will skip the GraalVM compatibility check
label
Jan 19, 2024
dilanSachi
force-pushed
the
goaway-fix
branch
from
January 19, 2024 08:32
46f0787
to
062e41e
Compare
dilanSachi
force-pushed
the
goaway-fix
branch
from
January 19, 2024 08:38
062e41e
to
0f8cb19
Compare
dilanSachi
removed
the
Skip GraalVM Check
This will skip the GraalVM compatibility check
label
Jan 23, 2024
dilanSachi
force-pushed
the
goaway-fix
branch
from
January 24, 2024 06:02
d25b391
to
087805a
Compare
TharmiganK
reviewed
Jan 24, 2024
dilanSachi
added
the
Skip GraalVM Check
This will skip the GraalVM compatibility check
label
Jan 26, 2024
TharmiganK
reviewed
Jan 29, 2024
TharmiganK
reviewed
Jan 29, 2024
TharmiganK
reviewed
Jan 29, 2024
Co-authored-by: Krishnananthalingam Tharmigan <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 53 New issues |
TharmiganK
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes ballerina-platform/ballerina-library#4806
Examples
Checklist