Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the logic of GoAway frame handling in the client side #1833

Merged
merged 58 commits into from
Jan 29, 2024

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Jan 2, 2024

Purpose

Fixes ballerina-platform/ballerina-library#4806

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (7ebf4ec) 81.68% compared to head (e48aca0) 81.59%.
Report is 1 commits behind head on master.

Files Patch % Lines
...actimpl/sender/states/http2/SendingEntityBody.java 0.00% 8 Missing ⚠️
...tractimpl/sender/states/http2/SendingRstFrame.java 0.00% 7 Missing ⚠️
...ntractimpl/sender/states/http2/SendingHeaders.java 0.00% 6 Missing ⚠️
...tractimpl/sender/http2/Http2ConnectionManager.java 86.84% 1 Missing and 4 partials ⚠️
...ctimpl/sender/states/http2/EntityBodyReceived.java 0.00% 4 Missing ⚠️
...ractimpl/sender/states/http2/ReceivingHeaders.java 0.00% 4 Missing ⚠️
...mpl/sender/states/http2/WaitingFor100Continue.java 0.00% 4 Missing ⚠️
...in/java/io/ballerina/stdlib/http/api/HttpUtil.java 72.72% 0 Missing and 3 partials ⚠️
...rt/contractimpl/sender/http2/Http2ChannelPool.java 0.00% 3 Missing ⚠️
...ort/contractimpl/common/states/Http2StateUtil.java 50.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1833      +/-   ##
============================================
- Coverage     81.68%   81.59%   -0.09%     
  Complexity      562      562              
============================================
  Files           393      393              
  Lines         21366    21489     +123     
  Branches       4786     4797      +11     
============================================
+ Hits          17452    17534      +82     
- Misses         2922     2954      +32     
- Partials        992     1001       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi removed the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 8, 2024
@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 9, 2024
@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 19, 2024
@dilanSachi dilanSachi removed the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 23, 2024
ballerina/http_client_connection_pool.bal Outdated Show resolved Hide resolved
ballerina/http_client_connection_pool.bal Outdated Show resolved Hide resolved
ballerina/http_client_connection_pool.bal Outdated Show resolved Hide resolved
@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 26, 2024
changelog.md Outdated Show resolved Hide resolved
dilanSachi and others added 2 commits January 29, 2024 08:42
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

53 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dilanSachi dilanSachi merged commit be154a3 into ballerina-platform:master Jan 29, 2024
7 of 8 checks passed
@dilanSachi dilanSachi deleted the goaway-fix branch January 29, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a backend service returns a GOAWAY, client need to handle it without dropping next requests
2 participants