Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose evictable idle time for a connection #1841

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Jan 17, 2024

Purpose

$subject

Related - ballerina-platform/ballerina-library#5951

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests - There is already a transport level test for this configuration. Adding a ballerina level test would be much harder
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi marked this pull request as ready for review January 17, 2024 06:59
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (be259f3) 81.67% compared to head (269c0e8) 81.66%.
Report is 1 commits behind head on master.

Files Patch % Lines
...in/java/io/ballerina/stdlib/http/api/HttpUtil.java 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1841      +/-   ##
============================================
- Coverage     81.67%   81.66%   -0.01%     
  Complexity      562      562              
============================================
  Files           393      393              
  Lines         21354    21365      +11     
  Branches       4784     4786       +2     
============================================
+ Hits          17440    17447       +7     
- Misses         2923     2927       +4     
  Partials        991      991              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ballerina/http_client_connection_pool.bal Outdated Show resolved Hide resolved
ballerina/http_client_connection_pool.bal Outdated Show resolved Hide resolved
ballerina/http_client_connection_pool.bal Show resolved Hide resolved
ballerina/http_client_connection_pool.bal Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we check the spec as well? If we have a reference to this PoolConfiguration in the spec, then we need to update that as well

@dilanSachi
Copy link
Contributor Author

LGTM. Can we check the spec as well? If we have a reference to this PoolConfiguration in the spec, then we need to update that as well

We only have the PoolConfiguration mentioned in ClientConfiguration. There is no explicit record definition

@dilanSachi dilanSachi merged commit b46ca97 into ballerina-platform:master Jan 19, 2024
8 checks passed
@dilanSachi dilanSachi deleted the expose-evic-timeout branch January 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants