Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the perRoutePoolLatch when connection closes abruptly in H2 upgrade scenario #1842

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Jan 19, 2024

Purpose

$subject
Fixes ballerina-platform/ballerina-library#5955

Relevant test case is here - e1755c9

Couldnt add the test case to this PR as the TCPServer tests are not merged yet

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b46ca97) 81.37% compared to head (42b91bb) 81.68%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1842      +/-   ##
============================================
+ Coverage     81.37%   81.68%   +0.31%     
- Complexity        0      562     +562     
============================================
  Files           357      393      +36     
  Lines         19620    21366    +1746     
  Branches       4440     4786     +346     
============================================
+ Hits          15965    17453    +1488     
- Misses         2800     2920     +120     
- Partials        855      993     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@TharmiganK TharmiganK marked this pull request as ready for review January 19, 2024 09:43
@TharmiganK TharmiganK removed the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 19, 2024
@dilanSachi dilanSachi merged commit 746e9ce into ballerina-platform:master Jan 19, 2024
10 checks passed
@dilanSachi dilanSachi deleted the fix-error-hang branch January 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server hangs on when calling HTTP 1.1 application using HTTP client
2 participants