Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle client level header size validation response before sending to server #1849

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Handle client level header size validation response before sending to server #1849

merged 9 commits into from
Feb 1, 2024

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Jan 31, 2024 •
edited
Loading

Purpose

$subject

Related to ballerina-platform/ballerina-library#6000
Related to ballerina-platform/ballerina-library#3963
Related to ballerina-platform/ballerina-library#4461

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8913531) 81.35% compared to head (5b5e7f3) 81.62%.

Files Patch % Lines
...ort/contractimpl/common/states/Http2StateUtil.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1849      +/-   ##
============================================
+ Coverage     81.35%   81.62%   +0.27%     
- Complexity        0      562     +562     
============================================
  Files           357      393      +36     
  Lines         19744    21493    +1749     
  Branches       4451     4797     +346     
============================================
+ Hits          16062    17544    +1482     
- Misses         2827     2951     +124     
- Partials        855      998     +143

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi removed the Skip GraalVM Check This will skip the GraalVM compatibility check label Jan 31, 2024
@dilanSachi dilanSachi marked this pull request as ready for review February 1, 2024 04:36
TharmiganK
TharmiganK reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Feb 1, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dilanSachi dilanSachi merged commit 7261ac3 into ballerina-platform:master Feb 1, 2024
7 of 8 checks passed
@dilanSachi dilanSachi deleted the goaway-fix branch February 1, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuvindu Nuvindu Nuvindu left review comments

@TharmiganK TharmiganK TharmiganK approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

Assignees
No one assigned
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dilanSachi @TharmiganK @Nuvindu