Apply suggestions from the API review #51

Nuvindu · 2024-06-19T12:46:03Z

Description

$subject

codecov · 2024-06-23T09:55:43Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

ballerina/build.gradle

ballerina/types.bal

native/src/main/java/io/ballerina/lib/ldap/Client.java

native/src/main/java/io/ballerina/lib/ldap/ModuleUtils.java

ballerina/build.gradle

ballerina/tests/test.bal

native/src/main/java/io/ballerina/lib/ldap/Utils.java

.github/workflows/pull-request.yml

ballerina/build.gradle

ballerina/types.bal

native/src/main/java/io/ballerina/lib/ldap/CustomSearchEntryListener.java

native/src/main/java/io/ballerina/lib/ldap/CustomSearchResultListener.java

native/src/main/java/io/ballerina/lib/ldap/Utils.java

native/src/main/java/io/ballerina/lib/ldap/Client.java

native/src/main/java/io/ballerina/lib/ldap/Utils.java

native/src/main/java/io/ballerina/lib/ldap/Client.java

ThisaruGuruge

LGTM

Nuvindu and others added 14 commits June 19, 2024 18:14

Apply suggestions from the review

145ffeb

Remove redundant message field from ErrorDetails

e0587f6

Add Entry record type to represent entries in directory servers

90e0d34

Update test cases with the new changes

29a7edc

Fix native code with the new updates

dcd14a4

Fix API description in the documentation

1b79567

Remove skipping null values from the native code

de51976

Remove additional flags from pr build workflow

7ea661b

Update files to start a ldap server from a docker image

9e8c7e1

Support nil values in references field in the SearchResult record

ba5df71

Update test cases to support the schemas in openldap server

dfdafe2

Update gradle file to run ldap server on build

a11e768

Fix spot bugs in the code

127a8d8

Merge branch 'ballerina-platform:master' into new-apis

7b15b1c

ayeshLK reviewed Jun 24, 2024

View reviewed changes

ballerina/build.gradle Outdated Show resolved Hide resolved

ayeshLK reviewed Jun 24, 2024

View reviewed changes

ballerina/types.bal Outdated Show resolved Hide resolved

ayeshLK reviewed Jun 24, 2024

View reviewed changes

native/src/main/java/io/ballerina/lib/ldap/Client.java Outdated Show resolved Hide resolved

ayeshLK reviewed Jun 24, 2024

View reviewed changes

native/src/main/java/io/ballerina/lib/ldap/Client.java Outdated Show resolved Hide resolved

ayeshLK reviewed Jun 24, 2024

View reviewed changes

native/src/main/java/io/ballerina/lib/ldap/ModuleUtils.java Outdated Show resolved Hide resolved

Nuvindu added 2 commits June 24, 2024 13:08

Apply review suggestions

05be8c1

Make the Client class final

12fcc9c