Improve Utils class usage

ballerina-platform · Nov 19, 2024 · 5a6c58d · 5a6c58d
1 parent 5a57977
commit 5a6c58d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 62 deletions.
diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/listener/MqttListenerCallbackImpl.java b/native/src/main/java/io/ballerina/stdlib/mqtt/listener/MqttListenerCallbackImpl.java
@@ -29,7 +29,6 @@
 import io.ballerina.runtime.api.values.BString;
 import io.ballerina.stdlib.mqtt.utils.MqttConstants;
 import io.ballerina.stdlib.mqtt.utils.MqttUtils;
-import io.ballerina.stdlib.mqtt.utils.Util;
 import org.eclipse.paho.mqttv5.client.IMqttToken;
 import org.eclipse.paho.mqttv5.client.MqttCallback;
 import org.eclipse.paho.mqttv5.client.MqttClient;
@@ -111,16 +110,20 @@ private void invokeOnMessage(MqttMessage message, String topic) {
             }
             try {
                 Object result = runtime.callMethod(service, MqttConstants.ONMESSAGE, null, bMqttMessage, callerObject);
-                Util.notifySuccess(result);
+                if (result instanceof BError error) {
+                    error.printStackTrace();
+                }
             } catch (BError bError) {
-                Util.notifyFailure(bError);
+                bError.printStackTrace();
             }
         } else {
             try {
                 Object result = runtime.callMethod(service, MqttConstants.ONMESSAGE, null, bMqttMessage);
-                Util.notifySuccess(result);
+                if (result instanceof BError error) {
+                    error.printStackTrace();
+                }
             } catch (BError bError) {
-                Util.notifyFailure(bError);
+                bError.printStackTrace();
             }
         }
     }
@@ -132,9 +135,11 @@ private void invokeOnError(BError bError) {
         }
         try {
             Object result = runtime.callMethod(service, MqttConstants.ONERROR, null, bError);
-            Util.notifySuccess(result);
+            if (result instanceof BError error) {
+                error.printStackTrace();
+            }
         } catch (BError error) {
-            Util.notifyFailure(error);
+            bError.printStackTrace();
         }
     }
 
@@ -146,9 +151,11 @@ private void invokeOnComplete(IMqttToken token) {
         bMqttToken = getMqttDeliveryToken(token);
         try {
             Object result = runtime.callMethod(service, MqttConstants.ONCOMPLETE, null, bMqttToken);
-            Util.notifySuccess(result);
+            if (result instanceof BError error) {
+                error.printStackTrace();
+            }
         } catch (BError bError) {
-            Util.notifyFailure(bError);
+            bError.printStackTrace();
         }
     }
 

diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/utils/Util.java b/native/src/main/java/io/ballerina/stdlib/mqtt/utils/Util.java