Make createIntInRange work for full int range
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid `int range overflow` error `startRange` and `endRange` are converted to decimal. Fixes the issue #4744.
|
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 22 22
Branches 11 11
=========================================
Hits 22 22
☔ View full report in Codecov by Sentry. |
|
@vil02 The fix looks good, before we accept the solution could you do the following?
Thanks! |
In order to be consistent with the code base, the files were formatted. This change is a result of running the command `bal format`.
Information about solving #4744 was addes to the changelog.
|
Code was formatted in: 80cfe22. @niveathika thanks for the tip with |
niveathika
approved these changes
Oct 9, 2023
|
@vil02 Looks good! 👏🏽👏🏽👏🏽 Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes ballerina-platform/ballerina-library#4744
Examples
The code like
no longer causes
int range overflowerror.Checklist
Other remarks for reviewers
random:createIntInRangewith an empty range ballerina-library#4892