Fix reveiw comments

ballerina-platform · Apr 26, 2024 · f49dfce · f49dfce
1 parent e77e8e5
commit f49dfce
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/ballerina/modules/soap11/tests/http_soap_service.bal b/ballerina/modules/soap11/tests/http_soap_service.bal
@@ -28,11 +28,8 @@ crypto:PublicKey serverPublicKey = check crypto:decodeRsaPublicKeyFromTrustStore
 
 service / on new http:Listener(9090) {
 
-    resource function post .(http:Request request) returns http:Response|error {
-        http:Response response = new;
-        xml payload = xml `<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><AddResponse xmlns="http://tempuri.org/"><AddResult>5</AddResult></AddResponse></soap:Body></soap:Envelope>`;
-        response.setPayload(payload);
-        return response;
+    resource function post .() returns xml|error {
+        return xml `<soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><AddResponse xmlns="http://tempuri.org/"><AddResult>5</AddResult></AddResponse></soap:Body></soap:Envelope>`;
     }
 
     resource function post getPayload(http:Request request) returns http:Response|error {

diff --git a/ballerina/modules/soap11/tests/soap11_client_test.bal b/ballerina/modules/soap11/tests/soap11_client_test.bal
@@ -252,7 +252,7 @@ function testSendReceiveWithHeaders() returns error? {
 }
 
 @test:Config {
-    groups: ["soap11", "q"]
+    groups: ["soap11"]
 }
 function testTransportBindingError() returns error? {
     Client|Error soapClient = new ("http://localhost:9090",
@@ -263,7 +263,7 @@ function testTransportBindingError() returns error? {
 }
 
 @test:Config {
-    groups: ["soap11", "q"]
+    groups: ["soap11"]
 }
 function testTransportBindingError2() returns error? {
     Client|Error soapClient = new ("http://localhost:9090",
@@ -296,7 +296,7 @@ function testSendReceiveError() returns error? {
 }
 
 @test:Config {
-    groups: ["soap11", "send_receive", "q"]
+    groups: ["soap11", "send_receive"]
 }
 function testSendReceiveWithTimestampTokenSecurity() returns error? {
     Client soapClient = check new ("http://localhost:9091",

diff --git a/ballerina/modules/soap12/tests/http_soap_service.bal b/ballerina/modules/soap12/tests/http_soap_service.bal
@@ -29,11 +29,8 @@ crypto:PublicKey serverPublicKey = check crypto:decodeRsaPublicKeyFromTrustStore
 
 service / on new http:Listener(9090) {
 
-    resource function post .(http:Request request) returns http:Response|error {
-        http:Response response = new;
-        xml payload = xml `<soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><AddResponse xmlns="http://tempuri.org/"><AddResult>5</AddResult></AddResponse></soap:Body></soap:Envelope>`;
-        response.setPayload(payload);
-        return response;
+    resource function post .() returns xml|error {
+        return xml `<soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><AddResponse xmlns="http://tempuri.org/"><AddResult>5</AddResult></AddResponse></soap:Body></soap:Envelope>`;
     }
 
     resource function post getPayload(http:Request request) returns http:Response|error {