Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply type inference in SOAP responses #112

Merged
merged 25 commits into from
Nov 3, 2023

Conversation

Nuvindu
Copy link
Contributor

@Nuvindu Nuvindu commented Nov 1, 2023

Purpose

Fixes: #5711

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e88443c) 93.04% compared to head (14d1d13) 96.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   93.04%   96.33%   +3.29%     
==========================================
  Files          12       12              
  Lines         388      409      +21     
  Branches      269      283      +14     
==========================================
+ Hits          361      394      +33     
+ Misses         27       15      -12     
Files Coverage Δ
ballerina/modules/wssec/ws_security_methods.bal 95.79% <100.00%> (+0.42%) ⬆️
ballerina/modules/soap11/soap11.bal 97.43% <91.66%> (+6.52%) ⬆️
ballerina/modules/soap12/soap12.bal 95.12% <92.85%> (+18.80%) ⬆️
ballerina/soap_utils.bal 96.89% <95.83%> (+2.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ballerina/soap_utils.bal Outdated Show resolved Hide resolved
ballerina/modules/soap11/soap11.bal Outdated Show resolved Hide resolved
ballerina/modules/soap11/tests/http_soap_service.bal Outdated Show resolved Hide resolved
ballerina/modules/soap11/tests/http_soap_service.bal Outdated Show resolved Hide resolved
ballerina/modules/soap12/tests/http_soap_service.bal Outdated Show resolved Hide resolved
@ThisaruGuruge ThisaruGuruge merged commit cb38b51 into ballerina-platform:master Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SOAP Response Type Inference for User-Friendly Code
3 participants