Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ref Cursor support for the procedure call #702

Merged
merged 17 commits into from
Feb 22, 2024

Conversation

daneshk
Copy link
Member

@daneshk daneshk commented Feb 21, 2024

Purpose

Fixes: https://github.com/wso2-enterprise/internal-support-ballerina/issues/584

Testcase PR: ballerina-platform/module-ballerinax-oracledb#885

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@daneshk daneshk requested a review from niveathika as a code owner February 21, 2024 09:00
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ daneshk
❌ Danesh Kuruppu


Danesh Kuruppu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (7da2c15) 80.66% compared to head (bf6e343) 80.04%.

Files Patch % Lines
...eterprocessor/DefaultResultParameterProcessor.java 0.00% 15 Missing ⚠️
...ina/stdlib/sql/utils/ProcedureCallResultUtils.java 14.28% 5 Missing and 1 partial ⚠️
...a/stdlib/sql/nativeimpl/OutParameterProcessor.java 0.00% 5 Missing ⚠️
...ballerina/stdlib/sql/nativeimpl/CallProcessor.java 0.00% 3 Missing ⚠️
ballerina/types.bal 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #702      +/-   ##
============================================
- Coverage     80.66%   80.04%   -0.63%     
  Complexity      109      109              
============================================
  Files            45       45              
  Lines          3961     3993      +32     
  Branches        751      753       +2     
============================================
+ Hits           3195     3196       +1     
- Misses          512      542      +30     
- Partials        254      255       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ballerina/Dependencies.toml Outdated Show resolved Hide resolved
ballerina/Dependencies.toml Outdated Show resolved Hide resolved
niveathika
niveathika previously approved these changes Feb 22, 2024
Copy link
Contributor

@niveathika niveathika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@daneshk daneshk merged commit 9f25765 into ballerina-platform:master Feb 22, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants