Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the out parameter test failuer in Postgres DB #760

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Conversation

daneshk
Copy link
Member

@daneshk daneshk commented Dec 7, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#7445
Fixes: ballerina-platform/ballerina-library#7380

The fix introduced for the issue ballerina-platform/ballerina-library#7255 only addresses default result processors. When there is a custom processor, it still fails. This PR is to fix it.

With the fix, unit tests written in OutParameterProcessorTest.java is not valid, Hence removing them.

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (c57df5b) to head (44f2240).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...a/stdlib/sql/nativeimpl/OutParameterProcessor.java 50.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #760      +/-   ##
============================================
- Coverage     80.11%   79.82%   -0.30%     
  Complexity      109      109              
============================================
  Files            41       41              
  Lines          3933     3926       -7     
  Branches        666      666              
============================================
- Hits           3151     3134      -17     
- Misses          526      537      +11     
+ Partials        256      255       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 9, 2024

@daneshk daneshk marked this pull request as ready for review December 9, 2024 01:51
Copy link
Member

@RDPerera RDPerera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable the disabled tests in Oracledb module Enable postgresql tests disabled during Java21 migration
2 participants